Guest - Testers are needed for the reworked CDateTime core component. See... https://forum.kodi.tv/showthread.php?tid=378981 (September 29) x
  • 1(current)
  • 2
  • 3
  • 4
  • 5
  • 43
Release service.subtitles.subscene
#1
Hi there,

This is the support thread for the Subscene subtitles plugin for Kodi.

If you find a problem, please provide a debug log as described here: debug log (wiki)
I'm happy to help, but without a debug log it is nearly impossible to reproduce any issue.
Reply
#2
I've ran into a few issues:
- No ratings and no language flags. Could be solved with this:
Code:
listitem = xbmcgui.ListItem(label=item['lang']['name'],
                                label2=item['filename'],
                                iconImage=str(int(round(float(item['rating'])/2))),
                                thumbnailImage=item['lang']['2let'])

- if a movie has a ' in the name, it doesn't return any results, although I'm not sure if thats a new issue and was not already present in the frodo version.
Reply
#3
Hi BigNoid, thanks for you feedback.

I pushed a new version to github.
Unfortunately Subscene doesn't give precise ratings on its search result page. It just marks subtitles as good, neutral or bad. Currently I map good to 5 stars, neutral to 0 stars and discard the bad ones completely.
I checked the flag icon implementation against some other subtitle plugins, I give the same parameters as them to ListItem(), but for neither my plugin nor for the others it shows a flag icon, so I guess, flag icons are not in the core (yet).

I improved the search code a bit over the frodo version, so it now finds movies with an apostrophe as well as titles with a dot in it, which seems to trigger a direct file search on Subscene.
I tested it successfully for my library, but please continue testing it against some unusual titles with special chars and such to check if I caught all issues.
Reply
#4
Yes I saw. You either give 0 or 10. Flags are supported. Opensubtitles shows them. You have the right code, just the .gif should be removed as that is already added in core.

EDIT:
Thats already fixed i see on git. It's showing flags for me now.

EDIT2:
Search is also better now, nice Smile
Reply
#5
Ah, the missing flags were a skin issue. Now I see them too. Good. Smile
Reply
#6
Thumbs Up 
Nice work CrowleyAJ Smile. This addon was holding me back from updating XBMC
Reply
#7
I just pushed a new version, which shows the "sync" icon, when the name of the subtitle matches the file name of the video. This may give false positives on trivial file names.

TODO:
- better default sort, i.e. "sync" matches first
- manual search string support
Reply
#8
Thanks CrowleyAj is working perfect
Reply
#9
I pushed a new version to github, which now supports manually entered search strings and fixed a bug with episode matching for tv shows.
Reply
#10
Version 0.0.5 is on github:

I added a new feature, which is handy when only season packs are available for certain TV shows. You can now choose to download archives with multiple files, when available. However only files matching the current episode code (SxxExx) are returned. All other files are discarded.

Please test.
Reply
#11
Using manual search I'm getting an error and don't downloads any subtitle.

Log:
http://xbmclogs.com/show.php?id=125878

Error related with params["find"]

I get the error Failed to Download Subtitles.

I'm using (XBMCSetup-20140130-e55212c-master) for Windows.
Reply
#12
I get the same error as Mafarricos
Reply
#13
Thanks for your report. This should be fixed now.
Reply
#14
seems to be working Smile
Thanks!
Reply
#15
Thanks for a fast fix Smile

I have another problem to report. It seems that it can only download one subtitle, if I watch another movie or episode and download a subtitle, then it wont show up. I have to restart XBMC to get it to work again.

Can also add that I have tried opensubtitles and it works everytime I download a subtitle.


Here is the log for first download that is working: http://pastebin.com/nLpAXbTZ

And here is the second download that is not working: http://pastebin.com/K07AdZhs

/sonic

Edit: Using latest nightly XBMC
Reply
  • 1(current)
  • 2
  • 3
  • 4
  • 5
  • 43

Logout Mark Read Team Forum Stats Members Help
service.subtitles.subscene8