[Numiah]

Thanks for your replies so far.
For example. I have three songs from Katy Perry.
Folder name : Katy Perry
File names inside that folder :
Katy Perry - Birthday.mkv
Katy Perry - Dark Horse.mkv
Katy Perry - Unconditionally.mkv

If I update the library I end up with three songs called "Lost".

I'm lost too

[zag]

as said, you need to put them in individual folders per music video, or one single folder.

I have 10,000 music vids ripped from youtube in a single folder and it works.

[olympia]

as said, you need to put them in individual folders per music video, or one single folder.

God, I will never ever understand this. I write RED, they read GREEN. Same in professional life. Must be something with me.

[Numiah]

Perhaps I need to clarify a bit.
When I put them in a single folder, or in a separate folder, or in folders named like the full song, it doesn't seem to make any difference naming wise.
They show up in the library after scanning, but the naming is off.
Only thing changed now is I end up with only the titles showing, but no artist and still no artwork.
I verified on other machines, and all three give the same result.

What makes it kinda frustrating is that other people seem to get it working instantly, in separate folders or all in one folder.

[olympia]

OK, let's enable debug logging, then create a test folder, add say 10 music vids into it, run the scraping and post the debug log via pastebin. We can advise more after seeing that.

[kmb32123]

I used this addon recently for the first time, and it had trouble finding matches for artists/titles that contained an apostrophe ( ' ).

I found that this could be fixed by replacing the apostrophe ( ' ) with backslash+apostrophe ( \' ) when adding manually the files to the library from within XMBC.

e.g.: The Weather Girls - It's Raining Men ---> The Weather Girls - It\'s Raining Men

Actually, the search field of TheAudioDB.com is doing this substitution. Just try searching for something and then in the results page see the text chain after "Search Results for...".

It would be nice if this could be implemented in the addon.

I ran into this same issue and workaround. Any word if this will be implemented upstream? It is an easy fix and was the reason the majority of my unscanned were remaining unscanned.

[Numiah]

OK, let's enable debug logging, then create a test folder, add say 10 music vids into it, run the scraping and post the debug log via pastebin. We can advise more after seeing that.

I really appreciate the fact that you're willing to help me. Thanks for that.
I did as requested.
Placed 11 files in a directory called music_video. Pointed XBMC (Kodi hehe) towards that directory.
Updated the library.
This time it kinda worked for 50%
I can see the song titles in the listing, see screenshots below.
As you can see the titles show correctly this time, artists aren't shown. Skin related? (Aeon MQ5)
For a few video's there is "some" artwork downloaded, but not all of it. No discart, no fanart, or wrong poster.
I switched to confluence for a few, but things look the same in there.
Dark Horse from Katy Perry got really close. There is some song info and even something that looks like a poster.
Are we on to something?

Here is the full pastebin : http://pastebin.com/HaHeBWJ8

watch gallery

[olympia]

I used this addon recently for the first time, and it had trouble finding matches for artists/titles that contained an apostrophe ( ' ).

I found that this could be fixed by replacing the apostrophe ( ' ) with backslash+apostrophe ( \' ) when adding manually the files to the library from within XMBC.

e.g.: The Weather Girls - It's Raining Men ---> The Weather Girls - It\'s Raining Men

Actually, the search field of TheAudioDB.com is doing this substitution. Just try searching for something and then in the results page see the text chain after "Search Results for...".

It would be nice if this could be implemented in the addon.

I ran into this same issue and workaround. Any word if this will be implemented upstream? It is an easy fix and was the reason the majority of my unscanned were remaining unscanned.

Please submit a PR or a patch if you think it is that easy.

[kmb32123]

So just found the source... This is interesting, I was expecting a python script or something. Maybe I'll have to take back the "easy" part. Anyways I'm doing my reading and we'll see what I come up with.

[kmb32123]

Please submit a PR or a patch if you think it is that easy.

So I got something working. Diff.

My Fix

Code:

    <CreateSearchUrl dest="3">
        <RegExp input="$$5" output="\1" dest="3">
            <!-- Start my addition -->
            <RegExp input="$$1" output="\1\\&apos;\2" dest="1">
                <expression repeat="yes">(.*[^\\])%27(.*)</expression>
            </RegExp>
            <!-- End my addition -->
            <RegExp input="$$1" output="&lt;url&gt;http://www.theaudiodb.com/api/v1/json/58424d43204d6564696120/searchtrack.php?s=\1&amp;amp;t=\2&lt;/url&gt;" dest="6">
                <expression trim="1,2">(.+)%20(?:%20|-)%20(.+)</expression>
            </RegExp>
            <RegExp input="$$6" output="\1" dest="5">
                <expression noclean="1" />
            </RegExp>
            <RegExp input="$$6" output="&lt;url&gt;http://www.theaudiodb.com/api/v1/json/58424d43204d6564696120/searchtrack.php?s=$$1&amp;amp;t=&lt;/url&gt;" dest="5">
                <expression>^$</expression>
            </RegExp>
            <expression noclean="1" />
        </RegExp>
    </CreateSearchUrl>

So find a %27(apostrophe) that has a character other than '\' before it. Then take the string in front, \', then the string in back and override the value in register 1. If no match is found leave 1 as is. I wrote it in hopes that it will work with multiple apostrophe in the name but I did not have a file to test on.

I'm putting together a PR now.

[olympia]

Can someone test this with multiple apostrophes before you submit the PR?

...and many thanks for picking this up!

[kmb32123]

So here is the PR. I just put some extra apostrophe in a filename and verified in the debug log that they were encoded. The final regex that works with this is not exactly pretty.

Code:

<RegExp input="$$1" output="\1\\&apos;\2" dest="1">
    <expression repeat="yes">((?:[^%]*(?:%20))*[^%]*)(?:%27)((?:[^%]*(?:%20))*[^%]*)</expression>
</RegExp>

[olympia]

Thank you!

To have it added, could you please submit the PR against the scraper repo, not mainline kodi?:
https://github.com/xbmc/repo-scrapers/tree/frodo

Thank you!

[kmb32123]

To have it added, could you please submit the PR against the scraper repo, not mainline kodi?:
https://github.com/xbmc/repo-scrapers/tree/frodo

You linked to the frodo branch. Should this be submitted to the master as well?

[olympia]

No