[un1versal]

First of all its an amazing and very complex addition to Kodi so whoever was/is involved should first of all be acknowledged because of the sheer dedication and hard work and patience it took to bring this support into Kodi.
From my part all I can say is how flabbergasting, chin dropping and amazing it is.

However as with all big projects its bound to have some kinks, its not surprising and to be expected, but nonetheless these things have to be reported so this is the reason for this thread.

So this will be a rolling thread for Audio DSP related issues now that its been merged into master and will make some commnets and report some of the issues noticed thus far.
Anyone is welcome to post their issues or solutions here.

After a small test found some issues some serious some not so serious and to be honest not sure if Im doing it right.

1) adsp.basic addon fails to compile. This is a build log for all the 3 addons -> http://pastebin.com/Anz7mB86 Fixed by https://github.com/kodi-adsp/adsp.basic/pull/3
2) Enabling an addon when dsp is enabled shows DSP add-on is currently in use and can't be removed. it should be The DSP add-on is currently in use and can't be modified.
3) Regarding 2) messages its mentioned this already in PR but was not even replied to DSP add-on is currently in use and can't be removed. according to AlwinEsch that message was removed see discussion but it was re-added by AchimTuran
4) This message is not displayed The audio DSP manager has been enabled without any enabled DSP add-on. Enable at least one add-on in order to use the audio DSP functionality. Fixed in current master

5) adsp.biquad.filters seems to hang Kodi sometimes and does odd things, like audio stops coming out the speakers (even though some faint murmur comes out LFE) and playback time still continues, (when you select audio speaker setup and pick biquad) Debug log http://pastebin.com/2QVgjXB3 Seems like a huge memory leak somewhere when this happens If you leave it audio comes back in next track.

Code:

PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND
7846 kodi      20   0 2243796 210588  60812 S 110.8  5.2   3:02.03 kodi.bin

6) adsp.freesurround Just keeps crashings Kodi with segmentation fault http://pastebin.com/q4xWhKA1 atm its unusable here.

7) Empty settings with no strings I think AlwinEsch had it at some stage working properly with the messages fixed up. Fix proposed https://github.com/kodi-adsp/adsp.biquad.filters/pull/3

This missing string should be: Enable pre-processing - Parametric EQ




8)Kodi AudioDSP settings are lost on AudioDSP crash, If you had enabled any addons and even DSP was enabled, on a crash (hapens often at this stage) when Kodi restarts (in case of upstart script and minimal Ubuntu) You are taken the addon manager window?!!!? See any of the crash-logs posted for freesurround crash

9) Slider dialog for audio sync has no title Fix Proposed https://github.com/xbmc/xbmc/pull/7569

Note on Issue 10)
Existing one

https://github.com/xbmc/xbmc/blob/ea251f...#L317-L321

DSP one

https://github.com/xbmc/xbmc/blob/master...#L629-L633

Code duplication: Cant understand the need to duplicate code like the common dialogs and things of this kind that already exist. But then I dont understand enough to make it any better.

10) Slider dialog for audio sync / subtitle delay offset dialogs does not respect remote mapping for AudioDelayMinus / AudioDelayPlus SubtitleDelayMinus / SubtitleDelayPlus when setup.

11) Add-ons show uninstall button in addon manager (But these are binary addons they cant be removed or uninstalled which is why issue 4) is about and that message is redundant.
This is especially wrong since pressing uninstall removes the addon from addon manager listing but on Kodi restart Add-on is back since you cant uninstall system files

12) adsp.basic addon is unusable for the most part, when activating any of the features music playback stops huge memory usage and you cant get back any audio until Kodi is restarted. (will grab logs soon enough.

I expect some sense decorum is maintained by all participants in here.

[wsnipex]

re building: https://github.com/kodi-adsp/adsp.basic/pull/3/files should fix it

[un1versal]

re building: https://github.com/kodi-adsp/adsp.basic/pull/3/files should fix it

Thx I suppose, Ive put a PR also to fix issue 7) and pending test a fix for 9) is already PR'ed to master

While messing around with the strings for addons I also fixed a few other issues so there's a few PRS in the addons needing review.

Edit:
User friendliness really odd behaiviours and things that go bump in the night.:

Its really odd that when DSP crashes or addons crash and because in my system Kodi restarts automatically, being taken to addon manager is IMO not right and if you restart kodi it will keep taking you there until you come back by hand.

If you enable DSP with no addons, it should Show you the message -> Keep DSP disabled (not keep it enabled since it pushes you to addons repo) -> open a DSP dynamic addon dialog (like it does elsewhere for other addons) or be taken straight to the DSP addons category.
ATM DSP remains enabled and you are pushed to addons manager (you have no choice as its automatic), if you enable a dsp addon you are told you cant since dsp is enabled and wont allow it, so back again you go, disable DSP and then go all the way back again to enable addons.
Thats just not user-friendly as is atm.

Some system messages (now Ive seen them in action) are just odd are poorly worded (I had reviewed these and even PR'd some changes that seem to have been lost), I will have a go at this now that its merged sooner rather than later.

Some dialogs are somewhat unbalanced and could do with a re-positioning and fit more with the skin, again these are just out loud thoughts (not moan or rant) of things that could do with some attention and some thought and re-factoring which probably are needed due to sheer amount of changes Kodi went through before this was finally pushed out/in

Its a shame AllwinEsq is having real life issues and I hope everyone can pull together to polish this up its a great addition and I cant wait to use it properly.

[AchimTuran]

@uNiversal:

If you read our wiki page about Development builds, you should know that the builds are very unstable I think at the moment it's not for daily use, but you can see where the feature will go:

Nightly Builds are made on a daily basis and contain the most recent changes. They are also the most unstable of the development builds, until "feature freeze" where only bug fixes are made.

Thanks for all your PRs, I will look deeper into it at the weekend.

I tried to merge ADSP, because of the issue with the merge windows. It was alot of work to integrate the code to the current changes. Also the add-ons are the moment quite unstable and under development. Only Alwin and I tested it. Now we need the community which tests the implementation and helps to improve it. On the other hand, it was the third time we tried to merge it and the implementation is now approximitly one year old. So you have just to wait if you wanna use it daily. It will be a nice feature.

Answers to your issues:

2) I know that message disappered. When my development try is updated to the newset version I will send and PR.

3) I added this strings, because the IDs were not removed in the source code. Before we lost some lines of code and I tried to minimize it. If it is not needed we can remove it.

5) It's because of the synchronous message system, which will be fixed in future version by a asynchronous message system. If you press the buttons slowly its not a problem.

6) On windows it works, but adsp.basic crahes.

7) Was still for testing and I forget to delete it.

10) I don't know this issue.

11) You're right and this should be removed.


From my side I also have questions:

1) Why not use the issue from github for each addon?
https://github.com/kodi-adsp/adsp.biquad.filters/issues
https://github.com/kodi-adsp/adsp.freesurround/issues
https://github.com/kodi-adsp/adsp.basic/issues

2) Maybe you haven't seen it but there is also a development subforum for ADSP. Could we use this one?

Its a shame AllwinEsq is having real life issues and I hope everyone can pull together to polish this up its a great addition and I cant wait to use it properly.

It's not a shame, we are a team and we are only so strong as the weakest segment in the chain.

On the other hand I'm very busy with my GSoC project, which ends at the end of august. After that I can only work on ADSP and improve it.

[un1versal]

I only use development builds for many years now, so I think I know the risks, thank you for pointing them out again.

And I realize fully that these things happen, issues happen its to be expected,especially after how long DSP has been waiting and how much Kodi changed in meanwhile, this is why I started this thread acknowledging such dedication and hard work, as I can only imagine how hard it was to achieve.

Now that's its been merged its time to start sorting them (like you said), so I started in my small way here it was easier for me. I hope you dont mind But Im not going to spend much time after today and tomorrow and Im limited to where I can help. I only realised after testing that the addons are still alpha (that explains the instability)

My last post I have some suggestions on DSP behaviour , what do you think about those? I found that could be improved and I wasnt sure if anyone mentioned it before (reading your thread one gets lost).

Answering your questions

2) You can move this thread to the DSP subforums if you like

Now If you want full bug reports in trac or github issues I can post this stuff there as well but....

1) Usually github issues not used for reporting issues around Kodi (We have been told not to) so I thought this applies to addons, and if you saying different for these addons that's fine with me, just make sure its fine for everyone else.

Issue 10) You can map remote buttons to Action IDs (wiki) and call the audio delay dialog or subtitles delay dialog (for current Kodi similar dialogs work both via menu or remote mapped action IDs), DSP does not care about action ID for these clone functions and it should, I think.

You are saying issue 7 is only there for testing? Thats not how it looks..
This missing string should be: Enable pre-processing - Parametric EQ Its just using the wrong ID according to strings the string issues in adsp-biquad are fixed in https://github.com/kodi-adsp/adsp.biquad.filters/pull/3

About AllwinEsq (not because he cant do this for now), he still having a hard time /issue with real life and personally hope he sees his way clear of such issues. Im sure in his absence things will go on.

Oh yea, Windows I dont use it so Im Linux + Kodi.

[wsnipex]

moved to ADSP dev section

[un1versal]

**snip**
Some system messages (now Ive seen them in action) are just odd are poorly worded (I had reviewed these and even PR'd some changes that seem to have been lost), I will have a go at this now that its merged sooner rather than later.
**snip**

Fixed by https://github.com/xbmc/xbmc/pull/7583

[alwinus]

Point 6 with crash of FreeSurround fixed with https://github.com/kodi-adsp/adsp.freesurround/pull/3

[alwinus]

Can be point 12 checked on the latest changes.

[un1versal]

if you enable building the adsp.basic in Lnux via kodi source sure last I checked it was disabled the one I currently have compiled is pre your latest fixes

[ironic_monkey]

you can use enable_adsp@notspiff/xbmc

[un1versal]

Hows that again?

[ironic_monkey]

It is a branch in my clone where i have enabled the adsps for you.

[un1versal]

Can be point 12 checked on the latest changes.

Seems that is resolved with latest code changes, cant duplicate, tested with video/audio.

@alwinus can you please look at 2 and 3? I would fix 2 (worng message) but according to last discussion https://github.com/AlwinEsch/kodi/commit...t-11225312 that was removed but seemingly it managed to make a re-entry.

[AchimTuran]

5, 6, 8, 12 should be fixed with latest PRs and addon versions.