[BytEvil]

Hello friends! Force closing Kodi after disabling audio DSP processing from System settings and by pressing OK in advanced settings (Audio DSP Manager). Here is video1 and video2

Kodi (16.0-BETA3 Git:2015-11-30-f6770a5-dirty). Platform: Arch Linux x86 64-bit.

Here is crashlog.

[AchimTuran]

Just a few questions:
1) Did you compile kodi from scratch or try the nightly version?
2) Did you use only adsp.biquad.filters?
3) Did you use the latest version of biquad.filters?
4) Is there a settings file in userdata from biquad.filters? (Something with *.xml)

[alwinus]

Hi @BytEvil

can you also start kodi and connect gdb (debugger) on command line to them with:

Code:

gdb --pid=$(pidof kodi.bin)

this connect then and kodi frezze.
Go then with the following keys.
'c' <- continue work of kodi

Then bring kodi to the crash, gdb freeze then the work and you need then to press this keys on command line:
'bt' <- Brings last processed point where it has crashed.

you can also use:
'thread apply all bt' <- Brings last processing points of all processes (is then a bit more)

On end only:
'q' <- closes gdb and kodi is away.

Can you give us then the output from them. Then we know the exact source and can be fixed.
Sorry for this way.

[un1versal]

Just install gdb and duplicate the crash conditions, then the step above are automatically processed into the crashlog.

[BytEvil]

Can`t compile addon for test from git:

Code:

Could not find a package configuration file provided by "platform" with any
  of the following names:

    platformConfig.cmake
    platform-config.cmake

because platform-config.cmake renamed to p8-platform-config.cmake.

See here: https://github.com/Pulse-Eight/platform

[Martijn]

then don't use the "latest" as platform but take tagged version https://github.com/Pulse-Eight/platform/...tag/1.0.10 or the one before the change

[BytEvil]

Disabling Audio DSP addon from System settings:
(gdb) c

Code:

Program received signal SIGSEGV, Segmentation fault.
0x0000000000e6c280 in std::_Rb_tree<ISubSettings*, ISubSettings*, std::_Identity<ISubSettings*>, std::less<ISubSettings*>, std::allocator<ISubSettings*> >::_M_erase(std::_Rb_tree_node<ISubSettings*>*) ()

(gdb) bt

Code:

#0  0x0000000000e6c280 in std::_Rb_tree<ISubSettings*, ISubSettings*, std::_Identity<ISubSettings*>, std::less<ISubSettings*>, std::allocator<ISubSettings*> >::_M_erase(std::_Rb_tree_node<ISubSettings*>*) ()
#1  0x0000000000e6b588 in CSettingsManager::~CSettingsManager() ()
#2  0x00007fec5d1e2841 in CBiquadFiltersSettings::~CBiquadFiltersSettings() ()
   from /usr/local/lib/kodi/addons/adsp.biquad.filters/adsp.biquad.filters.so
#3  0x00007feccf86d2ef in __cxa_finalize () from /usr/lib/libc.so.6
#4  0x00007fec5d1e14a3 in ?? () from /usr/local/lib/kodi/addons/adsp.biquad.filters/adsp.biquad.filters.so
#5  0x00007ffcb5c861e0 in ?? ()
#6  0x00007fecd71c3397 in _dl_close_worker () from /lib64/ld-linux-x86-64.so.2
Backtrace stopped: frame did not save the PC

In DSP Manager settings (when press OK for save EQ settings):
(gdb) c

Code:

Program received signal SIGSEGV, Segmentation fault.
0x0000000000e6c1d8 in std::_Rb_tree<std::string, std::pair<std::string const, ISettingControlCreator*>, std::_Select1st<std::pair<std::string const, ISettingControlCreator*> >, std::less<std::string>, std::allocator<std::pair<std::string const, ISettingControlCreator*> > >::_M_erase(std::_Rb_tree_node<std::pair<std::string const, ISettingControlCreator*> >*) ()

(gdb) bt

Code:

#0  0x0000000000e6c1d8 in std::_Rb_tree<std::string, std::pair<std::string const, ISettingControlCreator*>, std::_Select1st<std::pair<std::string const, ISettingControlCreator*> >, std::less<std::string>, std::allocator<std::pair<std::string const, ISettingControlCreator*> > >::_M_erase(std::_Rb_tree_node<std::pair<std::string const, ISettingControlCreator*> >*) ()
#1  0x0000000000e6b5fc in CSettingsManager::~CSettingsManager() ()
#2  0x00007f50a160f841 in CBiquadFiltersSettings::~CBiquadFiltersSettings() ()
   from /usr/local/lib/kodi/addons/adsp.biquad.filters/adsp.biquad.filters.so
#3  0x00007f50be5562ef in __cxa_finalize () from /usr/lib/libc.so.6
#4  0x00007f50a160e4a3 in ?? () from /usr/local/lib/kodi/addons/adsp.biquad.filters/adsp.biquad.filters.so
#5  0x00007ffdddf139c0 in ?? ()
#6  0x00007f50c5eac397 in _dl_close_worker () from /lib64/ld-linux-x86-64.so.2
Backtrace stopped: frame did not save the PC

Jarvis latest from git (c8b3fc894ea4a78b28045d81ce0f2edf57b1e9c5)

No settings file in userdata from biquad.filters...

then don't use the "latest" as platform but take tagged version https://github.com/Pulse-Eight/platform/...tag/1.0.10 or the one before the change

Thanks, Martijn!

[AchimTuran]

Did you try othter ADSP add-ons?

Sorry but your trace is not very helpful. I couldn't see the issues.

[BytEvil]

Sorry but your trace is not very helpful. I couldn't see the issues.

Latest crashlog is here.

Kodi 16.0-RC1 Git:2016-01-21-981b7dd.

[kevmegforest]

Will this be stable for the final release of Jarvis in Linux and Openelec.
This is one of the best addon ever made. I can finally ditch the stupid AVR.

[AchimTuran]

Sorry but your trace is not very helpful. I couldn't see the issues.

Latest crashlog is here.

Kodi 16.0-RC1 Git:2016-01-21-981b7dd.

I guess your issue is something in my functions for XML settings saving. Currently I work on a refactor of adsp.template and afterwards I will try to fix it.

[un1versal]

Can you please explain why the guisettings.xml is spammed with ~90 entries of <masterprocess_0_0>0</masterprocess_0_0>?

this is an extract of guisettings.xml, its the complete <defaultaudiosettings> </defaultaudiosettings> section

http://pastebin.com/JmcDCqWi

from v17 master fyi but I tested the adsp stuff since v16 always master trunk

[alwinus]

Hi @un1versal,

comes to use on different stream formats different defaults.

The first number is to identify the source type e.g. music or video and the second to identify the source e.g. mpeg2, dolby digital (AC3) or DTS.

One reason is to allow on a video stream with Dolby Digital the use of Dolby Digital EX (currently no add-on for it) as a default for master mode or on music only the minimum stereo upmix as default and for videos with stereo only the FreeSurround.

The use of numbers (equal with memory pointers) was from processing mutch more easy as for every possible way using of string compare (who need then mutch more CPU work).

[un1versal]

90 of them?

[alwinus]

They are also predefined for stream types like phone (which are currently not in) to prevent problems after it come, see here for types https://github.com/xbmc/xbmc/blob/master...#L158-L164