[s.maciek]

So ... firstly, i turned off watched-dog but nothing really happened, i did not manage to find that file you mentioned so I just renamed the database i am instaling it from - it did not help either. i have confirm dialog turned on all the time but nothing has ever appeared.

BUT when i tried to uninstall your addon strange thing happened - window to move and rate popped out, I clicked "no" but thats all. it appears only when i unsitall your addon.

http://xbmclogs.com/pw8lmhbws

edit: i found a folder \\...\Userdata\addon_data\ but there I found only script.afterwatch so name was good.

Edit2: updated new log

[jvandenbroek]

So ... firstly, i turned off watched-dog but nothing really happened, i did not manage to find that file you mentioned so I just renamed the database i am instaling it from - it did not help either. i have confirm dialog turned on all the time but nothing has ever appeared.

BUT when i tried to uninstall your addon strange thing happened - window to move and rate popped out, I clicked "no" but thats all. it appears only when i unsitall your addon.

http://xbmclogs.com/pw8lmhbws

edit: i found a folder \\...\Userdata\addon_data\ but there I found only script.afterwatch so name was good.

Edit2: updated new log

Thanks for this info, that helped me (I think ). Did you remove the 'delay confirm dialog' value? I tested this and indeed it will hang forever, just as in your case, which I'm going to fix. Make sure you fill in at least a number, 0 will be fine.

[edit]Ah well, after testing, 0 also seems to hang indefinitely. That seems to be the problem, I always test with some higher value filled in here. So set it to 1 for now and it will work. Try to push an update today, thanks for debugging this![/edit]

[jvandenbroek]

New release 0.9.5
* Added remove from library option (no full clean up necessary)
* No longer display dialogs for preserve, rating and tagging
* Fixed infinite hanging when confirmation dialog delay set to 0 (default) or empty
* Started splitting and cleaning up code
* Renamed add-on to script.service.afterwatch in compliance with Kodi rules
* Other minor fixes

Download here: https://raw.githubusercontent.com/jvande...rwatch.zip
It's highly recommended to update to this new version, since a lot of stuff is changed and fixed.

I've renamed the add-on from script.afterwatch to script.service.afterwatch to be in compliance with the Kodi standard (see http://kodi.wiki/view/Add-on_Structure#Directory_Name). Unfortunately it's necessary to manually remove the old folder named .kodi/addons/script.afterwatch. If you want to keep your current settings, rename .kodi/userdata/addon_data/script.afterwatch to .kodi/userdata/addon_data/script.service.afterwatch before installing this new version (or remove the new one and rename the old one after)

As always, let me know if there are any issues (including a debug log helps a lot). Thanks!

[s.maciek]

So ... firstly, i turned off watched-dog but nothing really happened, i did not manage to find that file you mentioned so I just renamed the database i am instaling it from - it did not help either. i have confirm dialog turned on all the time but nothing has ever appeared.

BUT when i tried to uninstall your addon strange thing happened - window to move and rate popped out, I clicked "no" but thats all. it appears only when i unsitall your addon.

http://xbmclogs.com/pw8lmhbws

edit: i found a folder \\...\Userdata\addon_data\ but there I found only script.afterwatch so name was good.

Edit2: updated new log

Thanks for this info, that helped me (I think ). Did you remove the 'delay confirm dialog' value? I tested this and indeed it will hang forever, just as in your case, which I'm going to fix. Make sure you fill in at least a number, 0 will be fine.

[edit]Ah well, after testing, 0 also seems to hang indefinitely. That seems to be the problem, I always test with some higher value filled in here. So set it to 1 for now and it will work. Try to push an update today, thanks for debugging this![/edit]

Great! Thanks for your help. I installed your new version, set the delay on 1 (is it 1 second or minute?) and now it asks me to move the file (will check it with watch-dog addon turned on later on).

BUT ... it takes like a few minutes to move it to the specified folder (on the same mounted drive) what is kinda strange, coz when i do i t manualy from my pc it takes 1 second. I have alternative copying style turned ON. Do you know why is that? Will it always take that "long time"?
How does it work, does it copy it firstly and then it deletes or what?

Thanks for your help, Maciej.

edit: after changing turning alternative way of moving to OFF it moves files instantly! Success!

[jvandenbroek]

So ... firstly, i turned off watched-dog but nothing really happened, i did not manage to find that file you mentioned so I just renamed the database i am instaling it from - it did not help either. i have confirm dialog turned on all the time but nothing has ever appeared.

BUT when i tried to uninstall your addon strange thing happened - window to move and rate popped out, I clicked "no" but thats all. it appears only when i unsitall your addon.

http://xbmclogs.com/pw8lmhbws

edit: i found a folder \\...\Userdata\addon_data\ but there I found only script.afterwatch so name was good.

Edit2: updated new log

Thanks for this info, that helped me (I think ). Did you remove the 'delay confirm dialog' value? I tested this and indeed it will hang forever, just as in your case, which I'm going to fix. Make sure you fill in at least a number, 0 will be fine.

[edit]Ah well, after testing, 0 also seems to hang indefinitely. That seems to be the problem, I always test with some higher value filled in here. So set it to 1 for now and it will work. Try to push an update today, thanks for debugging this![/edit]

Great! Thanks for your help. I installed your new version, set the delay on 1 (is it 1 second or minute?) and now it asks me to move the file (will check it with watch-dog addon turned on later on).

BUT ... it takes like a few minutes to move it to the specified folder (on the same mounted drive) what is kinda strange, coz when i do i t manualy from my pc it takes 1 second. I have alternative copying style turned ON. Do you know why is that? Will it always take that "long time"?
How does it work, does it copy it firstly and then it deletes or what?

Thanks for your help, Maciej.

edit: after changing turning alternative way of moving to OFF it moves files instantly! Success!

Good to hear it works! Delay is in seconds and you can actually now just leave it at 0 or empty, that's fixed in this release. The alterate file method is indeed slow when moving files locally, you should only use that if source and/or destination is a SMB/NFS share (which doesn't allow direct file i/o). So alternate method disabled is perfect in your case.

[KevinSartori]

Hello jvandenbroek,

I just downloaded the latest build. Before installation, I deleted the After Watch folders in the addons and addon_data folders. It's listed as 0.9.5 in Kodi, but the changelog.txt lists it as 0.9.6 (2016-03-17).

When I try to delete a TV show, I get the following error in a dialog box:

global name 'alt_method' is not defined

Here's the log:

http://xbmclogs.com/prf7bavsf

Thanks!

[Blackkatt]

For me it won't download/install. Gets stuck on "downloading 0%" then it goes away and nothing has happens...

From the log

07:16:45 T:21864 NOTICE: Starting Kodi (16.1-RC1 Git:20160306-46d1480)
07:16:45 T:21864 NOTICE: Running on Windows 10, kernel: Windows NT x86 64-bit version 10.0


07:18:41 T:23444 ERROR: CCurlFile::Stat - Failed: HTTP response code said error(22) for http://hautopc.googlecode.com/svn/trunk/...leeper.exe
07:18:59 T:23444 ERROR: CCurlFile::FillBuffer - Failed: HTTP returned error 403
07:18:59 T:23444 ERROR: CCurlFile::Open failed with code 403 for http://hautopc.googlecode.com/svn/trunk/...leeper.exe
07:18:59 T:23444 ERROR: XFILE::CFileCache::Open - failed to open source <http://hautopc.googlecode.com/svn/trunk/xbmc/repository/script.hautopc.after-watch/resources/lib/Sleeper.exe>
07:18:59 T:23444 ERROR: CAddonInstallJob[script.hautopc.after-watch]: could not read addon description of special://home/addons/script.hautopc.after-watch

[jvandenbroek]

Hello jvandenbroek,

I just downloaded the latest build. Before installation, I deleted the After Watch folders in the addons and addon_data folders. It's listed as 0.9.5 in Kodi, but the changelog.txt lists it as 0.9.6 (2016-03-17).

When I try to delete a TV show, I get the following error in a dialog box:

global name 'alt_method' is not defined

Here's the log:

http://xbmclogs.com/prf7bavsf

Thanks!

Hi,

Sorry for the delay, didn't notice there were new posts
I'm not entirely sure you've got the latest additions, I changed a lot that day and possibly didn't update the zip. Pushed the add-on version to 0.9.6 and pushed my changes, could you re-download it from https://raw.githubusercontent.com/jvande...rwatch.zip and check if it's fine now?

You could just install it, no need to remove the previous manually. If it still is not working, please re-upload the debug log, it's no longer there.

[jvandenbroek]

For me it won't download/install. Gets stuck on "downloading 0%" then it goes away and nothing has happens...

From the log

07:16:45 T:21864 NOTICE: Starting Kodi (16.1-RC1 Git:20160306-46d1480)
07:16:45 T:21864 NOTICE: Running on Windows 10, kernel: Windows NT x86 64-bit version 10.0


07:18:41 T:23444 ERROR: CCurlFile::Stat - Failed: HTTP response code said error(22) for http://hautopc.googlecode.com/svn/trunk/...leeper.exe
07:18:59 T:23444 ERROR: CCurlFile::FillBuffer - Failed: HTTP returned error 403
07:18:59 T:23444 ERROR: CCurlFile::Open failed with code 403 for http://hautopc.googlecode.com/svn/trunk/...leeper.exe
07:18:59 T:23444 ERROR: XFILE::CFileCache::Open - failed to open source <http://hautopc.googlecode.com/svn/trunk/xbmc/repository/script.hautopc.after-watch/resources/lib/Sleeper.exe>
07:18:59 T:23444 ERROR: CAddonInstallJob[script.hautopc.after-watch]: could not read addon description of special://home/addons/script.hautopc.after-watch

You shouldn't use the obsolete version in the repository, but download this one and install as zip manually: https://raw.githubusercontent.com/jvande...rwatch.zip

[KevinSartori]

I'm not entirely sure you've got the latest additions, I changed a lot that day and possibly didn't update the zip. Pushed the add-on version to 0.9.6 and pushed my changes, could you re-download it from https://raw.githubusercontent.com/jvande...rwatch.zip and check if it's fine now?

That did it! I must have grabbed it before while you were in the middle of making changes!

Great job, by the way. It's really cool that a video can now be removed directly from the library without having to trigger a full library update!

Once again, great work!

[lovemyram4x4]

Nice to see someone update this very useful add-on. Glad to see that many of things I had to change in the code now has switches to turn on/off. Also great that it now deletes the -thumb files.

I did find an issue, it appears that if you have a showname.ext and showname(1).ext and choose to delete one after watching it deletes both. Normally I only have have showname(1) if I have duplicate shows unfortunately when I discovered this I was watching a show that probably had a recording failure after the first 19min so it had a second file with the same name but with a (1) at the end.

[jvandenbroek]

Nice to see someone update this very useful add-on. Glad to see that many of things I had to change in the code now has switches to turn on/off. Also great that it now deletes the -thumb files.

I did find an issue, it appears that if you have a showname.ext and showname(1).ext and choose to delete one after watching it deletes both. Normally I only have have showname(1) if I have duplicate shows unfortunately when I discovered this I was watching a show that probably had a recording failure after the first 19min so it had a second file with the same name but with a (1) at the end.

I looked into it, but this is difficult to change this without giving up effective cleaning. We want to match all remaining files containing the basename (showname in your example). But showname(1) and showname(2) would work fine, since those wouldn't match. Same for first watching 'snowname(1)', that's no match with 'snowname', but the other way around it does match. I guess it would be better to make sure you have snowname(1) and snowname(2) in case of multiple instances.

[lovemyram4x4]

I haven't looked at any of the new code yet but figured it had to do with the changes for the file clean up. I'll just be careful for now and not use any current versions of afterwatch to remove duplicate recordings unless I'm sure they're really duplicates. For some reason MCEbuddy has been renaming/scraping many series recordings without proper/complete guide data as S01 E01 so I won't use afterwatch on those either if there's more than one file.

I end up with (1) on second duplicate (2) on third, etc because I have MCEbuddy set up to not over right files so the first file doesn't have (X) at the end. So in case that I discovered the issue on a split recording the first part didn't have a (X) at the end.

Oh, I'm also glad you added that delay to afterwatch, that actually helped with an issue that just popped up on my Shield TV with the original modified(by me) afterwatch were the highlight for yes/no on confirmation would jump back the episode screen immediately after it popped up. Not sure why it started doing that all of a sudden and only on that one device, but that's the reason I decided to finally update to your new version.

[jvandenbroek]

I haven't looked at any of the new code yet but figured it had to do with the changes for the file clean up. I'll just be careful for now and not use any current versions of afterwatch to remove duplicate recordings unless I'm sure they're really duplicates. For some reason MCEbuddy has been renaming/scraping many series recordings without proper/complete guide data as S01 E01 so I won't use afterwatch on those either if there's more than one file.

I end up with (1) on second duplicate (2) on third, etc because I have MCEbuddy set up to not over right files so the first file doesn't have (X) at the end. So in case that I discovered the issue on a split recording the first part didn't have a (X) at the end.

Oh, I'm also glad you added that delay to afterwatch, that actually helped with an issue that just popped up on my Shield TV with the original modified(by me) afterwatch were the highlight for yes/no on confirmation would jump back the episode screen immediately after it popped up. Not sure why it started doing that all of a sudden and only on that one device, but that's the reason I decided to finally update to your new version.

Maybe I could hack in some code to match (0-9) in the end of the file name, it seems legit to handle these namings differently. The thing is that we want to match all remaining files, including subs for tons of languages and all sorts of custom files, which are hard to match with other methods then the one I used. I'll look into it tomorrow.

Sent from my SM-N9005 with Tapatalk

[TheFatherMind]

How come there is a different version in the repository that will not install?