Posts: 1,506
Joined: Nov 2013
2016-09-16, 11:57
(This post was last modified: 2016-09-16, 11:57 by ironic_monkey.)
nah, no strong feelings either way about that, just as long as it's a fixed number. i didn't see the patch reference..
Posts: 23,551
Joined: Aug 2011
Reputation:
1,108
fritsch
Team-Kodi Developer
Posts: 23,551
Let's see what will happen after he tested.
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Posts: 29
Joined: May 2012
Reputation:
0
amand
Junior Member
Posts: 29
I've tested your patched version and... I have a blank screen when I launch kodi, but the sound works!
I've tested again with the 17.0b2, and no blank screen...
Posts: 23,551
Joined: Aug 2011
Reputation:
1,108
fritsch
Team-Kodi Developer
Posts: 23,551
2016-09-16, 15:42
(This post was last modified: 2016-09-16, 15:46 by fritsch.)
Wait - what you just linked me is a 16.0-Beta2 - what's that? Are you running the wrong kodi by chance? Or a systemwide kodi with old share files?
Did you checkout my devcon16 branch?
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Posts: 29
Joined: May 2012
Reputation:
0
amand
Junior Member
Posts: 29
Ok...
Your patched version's working.
I've tested the waveform visualisation, and it seems to be ok!
On the contrary, my visualisation does not work anymore. I think this is due to the variation of iAudioDataLength.
I assumed in my test code that it is always 1024 (2x512 bytes, for left and right).
I investigate :-D
Thanks again!
Posts: 23,551
Joined: Aug 2011
Reputation:
1,108
fritsch
Team-Kodi Developer
Posts: 23,551
It's not pushed yet. Spiff anything special you'd propose? Your viz are the main users.
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Posts: 29
Joined: May 2012
Reputation:
0
amand
Junior Member
Posts: 29
By blocking the iAudioDataLength to 512, it works!
Now, if I understand, iAudioDataLength will differ if we use different soundcards, but the data values will always be the same for a constant number of data.
And the audio data are always stereo, despite the number of channels of the soundcard.
Is this correct?
Posts: 23,551
Joined: Aug 2011
Reputation:
1,108
fritsch
Team-Kodi Developer
Posts: 23,551
You always get Front Left and Front Right in float format and 44.1 khz and at least your 512 samples. I will PR now.
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Posts: 1,506
Joined: Nov 2013
sounds purrfect fritsch, thanks.
Posts: 29
Joined: May 2012
Reputation:
0
amand
Junior Member
Posts: 29
I tested this week-end, with waveform, and it works!
Therefore, sometimes, when I listen a complete album, after 3 or 4 songs, the viz stops to work. I don't know if it is a problem with waveform, and I have not gone on further testing.
I will investigate...
And... thanks again!