(2017-03-20, 17:24)d3mncln3r Wrote: Hey garbear can you give some insight into your bookmark strategy? I'm having trouble using it. The length of the timeframe is only 1 minute. After which it the timer just stays at the 1 minute mark. Loading a bookmark seems to take you to whatever time-position you saved it at relative to the 1 minute mark. For example if I save it at 30 seconds, then go on to play for 5 more minutes, the time frame is still at the 1 minute mark, and will load at 30 seconds prior to where I am. I'm not sure if that's a clear explanation, but basically the timer should count on to infinity, not stop at 1 minute.
The reason for 1 minute showing is becaues you have 1 minute buffered for which you can rewind. When full, seeking to zero seconds will rewind 60 seconds. It doesn't increase to infinity because you can't rewind past 1 minute. (Note that you can increase this up to 10 minutes in advanced game settings.)
Loading/saving has weird behavior because it was implemented after rewinding.
The ultimate problem is that we're trying to fit gameplay into the movie paradigm (where time can't increase forever). I initially chose this paradigm because it required less code changes, which was important in ever getting RetroPlayer merged. Now that it's merged, we should revisit this assumption.
The question is, what should we show? The length of the rewind buffer, or total play time? I would actually argue to show nothing, because like you said, rewind time doesn't make much sense, and some games I play so much I don't wanna be reminded how much total time I've wasted :p
I plan to totally rework how rewinding and saving/loading works, so I'm open to ideas in how this should be done.