• 1
  • 57
  • 58
  • 59(current)
  • 60
  • 61
  • 88
v17 Horizon - Krypton
The other sort of strange thing is that you're setting a default value for the artwork param as "Window(Home).Property(SkinHelper.ListItem.Art.Fanart)", so shouldn't the fanart be showing up there if it can't find ListItem.Icon?
Reply
(2017-09-13, 12:00)jurialmunkey Wrote: @Blurayx - nope. That was the first I saw for that one. I've been using 6.x because I need the manual entry feature. I just noticed a few people mention having problems.

No worries Smile

There are many bugs but the ones I've reported so far are:

1) Missing TV Shows

2) Duplicated tv shows, When the first and second options are selected in the settings
Setup: LG OLED65B7 | Onkyo TX-RZ50 | OPPO UDP-203 4K Blu-Ray player | Nvidia Shield TV | Dune HD Homatics Box R 4K Plus | KEF T205
My Favourite Skin: Arctic Fuse mod
Reply
(2017-09-14, 00:16)jurialmunkey Wrote: @karlshea - And the artwork definitely shows in Arctic in pvr recordings window? I'm not sure why it wont show if that is the case because I'm using the same infolabel (ListItem.Icon). I pushed another test if you can see if that works? If it doesn't, I have one more idea to try and if that doesn't work then I will need to just revert it back to the fanart I guess.

Sent you a pull request (https://github.com/jurialmunkey/skin.horizon/pull/4)
Reply
(2017-09-14, 00:55)karlshea Wrote: The other sort of strange thing is that you're setting a default value for the artwork param as "Window(Home).Property(SkinHelper.ListItem.Art.Fanart)", so shouldn't the fanart be showing up there if it can't find ListItem.Icon?
It doesn't work like that. The default value for a param is only filled if another value isn't passed to it. Params are basically like cutting and pasting code - it doesn't actually do any checks, it just replaces the $PARAM with whatever text it is passed.

(2017-09-14, 01:43)karlshea Wrote: Sent you a pull request (https://github.com/jurialmunkey/skin.horizon/pull/4)
Yeah the method you are using was going to be my last resort.

Can you try the latest commit I just pushed. Hopefully it will give thumb images and fallback to fanart images if there are none, but still avoid using Default images. Otherwise, I'm going to have to go with the method in your pull request.

Also, I really appreciate you testing this. PVR is really difficult to skin now that I don't have a working setup for it!

EDIT: Also, just a FYI - the 9123 control id is basically a way to be able to get the text label for the texture used. That's how I'm attempting to hide the default icons - because I use a string compare to check if it is trying to use an image that starts with Default. It is possible that is the culprit, so I've tried a slightly different arrangement with it, but it might just be refusing to work altogether (which is strange, because I use this method elsewhere and it works fine).
Arctic Fuse 2 - Alpha now available. Support me on Ko-fi.
Reply
(2017-09-14, 01:49)jurialmunkey Wrote:
(2017-09-14, 00:55)karlshea Wrote: The other sort of strange thing is that you're setting a default value for the artwork param as "Window(Home).Property(SkinHelper.ListItem.Art.Fanart)", so shouldn't the fanart be showing up there if it can't find ListItem.Icon?
It doesn't work like that. The default value for a param is only filled if another value isn't passed to it. Params are basically like cutting and pasting code - it doesn't actually do any checks, it just replaces the $PARAM with whatever text it is passed.

Ahh makes sense.

(2017-09-14, 01:49)jurialmunkey Wrote:
(2017-09-14, 01:43)karlshea Wrote: Sent you a pull request (https://github.com/jurialmunkey/skin.horizon/pull/4)
Yeah the method you are using was going to be my last resort.

Can you try the latest commit I just pushed. Hopefully it will give thumb images and fallback to fanart images if there are none, but still avoid using Default images. Otherwise, I'm going to have to go with the method in your pull request.

Also, I really appreciate you testing this. PVR is really difficult to skin now that I don't have a working setup for it!

EDIT: Also, just a FYI - the 9123 control id is basically a way to be able to get the text label for the texture used. That's how I'm attempting to hide the default icons - because I use a string compare to check if it is trying to use an image that starts with Default. It is possible that is the culprit, so I've tried a slightly different arrangement with it, but it might just be refusing to work altogether (which is strange, because I use this method elsewhere and it works fine).

The last changes work! The only thing that still doesn't appear to work is the fanart background inside the show folder. In the recordings folder that displays the list of shows, each show's fanart shows up in the background and also in Object_PVR_Info

Image

Image

Edit: > Also, I really appreciate you testing this. PVR is really difficult to skin now that I don't have a working setup for it!

Not a problem at all! I'm very familiar with the horrors of trying to debug something I can't see.
Reply
(2017-09-14, 01:55)karlshea Wrote: The only thing that still doesn't appear to work is the fanart background inside the show folder. In the recordings folder that displays the list of shows, each show's fanart shows up in the background and also in Object_PVR_Info

I think nevermind on this, some of the episodes show it and some don't. I'm guessing this is actually a SkinHelper or MythTV issue instead.
Reply
@karlshea -- Yes! Success!!! Big Grin

Excellent, I'm really happy it is working properly now. Yeah, the background fanart is likely just skin helper not pulling in the fanart properly. You can set fanart manually by opening the context menu (C on the keyboard and some remotes it is a long press of OK) and selecting "Artwork Options".

EDIT: Also, looking at your screenshots it looks like I need to fix the folder names to show in the info.
EDIT2: Ok, that should be fixed now too.
Arctic Fuse 2 - Alpha now available. Support me on Ko-fi.
Reply
(2017-09-14, 02:26)jurialmunkey Wrote: @karlshea -- Yes! Success!!! Big Grin

Excellent, I'm really happy it is working properly now. Yeah, the background fanart is likely just skin helper not pulling in the fanart properly. You can set fanart manually by opening the context menu (C on the keyboard and some remotes it is a long press of OK) and selecting "Artwork Options".

There's something else going on with the PVR recording fanart, it's just super flaky and makes no sense. Doing anything in Artwork Options seems to make next to no difference, and all sorts of crazy shit is happening with it.

Like there will be a show folder with one episode in it. No fanart background when show folder is highlighted, but there will be fanart on the single episode. Or half the episodes will show a fanart background, and some won't, and those aren't always the same depending on which way you go through the list. I tried disabling online lookup in the Artwork and Metadata advanced settings and that seems to have made it a little better, but I'm thinking it's actually an issue with either missing fanart in my MythTV install, or some issue with pvr.mythtv or SkinHelper.

(2017-09-14, 02:26)jurialmunkey Wrote: EDIT: Also, looking at your screenshots it looks like I need to fix the folder names to show in the info.
EDIT2: Ok, that should be fixed now too.

Sweet, yep that's working now!
Reply
I've searched through this thread and can't find any other post about this.

Some of my logos in Movies overlap the Plot text.

All my logos are 800 x 310px.

The skin seems to remove any blank space in the logo and fit it to the top corner.

Is there some option I need to change ?

Thanks, and great skin BTW, I'm moving from Arctic Zephyr to this.

watch gallery
Reply
@holdestmade -- Those overlapping ones are clearly not 800x310px, otherwise they wouldn't be square like that. Looks more like 310x310 or something like that. I've never encountered clearlogos like that... Anyway, I've added a fix so this shouldn't be able to happen any more.
Arctic Fuse 2 - Alpha now available. Support me on Ko-fi.
Reply
@holdestmade do you happen to use Emby? I remember about a year ago when i was using it that they remove the transparent bits from logos and clearart, so even if you added an image at 800x310 by the time you see it in Kodi would have changed
Reply
hey
first of all, this is the best and most stable skin I've ever seen comparing to the features it offers, I really love it. Thank you very much.
Anyway, here are some ideas which could make it even nicer :-)

PVR
- I think seeing just 3 channels at once is a little less and they look reaaaly big, so maybe making a smaller landscape widget here would be nice. Having some epg info when hovering over the channel icon would be great, too. At the moment you only see the channel name:

Image

- When entering the tv channels window, the picons are squashed:

Image

- In epg window, I'd like to be able to make the channel names disappear. As I'm having picons I don't need both so this will bring more room for the important epg info:

Image

Is there an option to get into the side menu from epg info? I don't see an option to switch between channel groups etc here.


Movie view Media Info 2


I love this view for movies, here is some brainstorming which maybe would make it even better:
I think what should be tried to accomplish, is getting as less running text as possible by eliminating redundant information.
You could remove the (green marked) rating on the right, because it is already available on the (green marked) left info line. Same for the red marked infos. Maybe you find a space-saving way for the (yellow marked) watched/unwatched/set indicator, too. Then the movie titles can be way longer before they become a running text.
Another idea is to remove the brown marked title on the left (if it won't get too confusing then), so the plot would have more place. And maybe putting the whole (blue marked) section more on top, this would give even more room for the plot. When this space is freed, maybe you'd think about adding info like movie tagline (which is currently not available in any view of the skin), budget and revenue (if this is possible without slowing it down too much).

Image


These are just my ideas, tell me what you think :-)

Thank you very much again!
Reply
(2017-09-14, 16:38)horstepipe Wrote: - I think seeing just 3 channels at once is a little less and they look reaaaly big, so maybe making a smaller landscape widget here would be nice. Having some epg info when hovering over the channel icon would be great, too. At the moment you only see the channel name
I've already addressed widget sizing questions multiple times in this thread. Short answer is no. All widgets have the same height. It is too much of a pain trying to manage the code and get the alignment correct when widgets have multiple heights.

If you want more/smaller widgets, then use the square widget. I just pushed an update that will retain the aspectratio of PVR icons rather than scale them for square widgets.

(2017-09-14, 16:38)horstepipe Wrote: - When entering the tv channels window, the picons are squashed:
Fixed Smile

(2017-09-14, 16:38)horstepipe Wrote: - In epg window, I'd like to be able to make the channel names disappear. As I'm having picons I don't need both so this will bring more room for the important epg info:

Is there an option to get into the side menu from epg info? I don't see an option to switch between channel groups etc here.

EPG is actually really picky about sizing of things. Plus I'm trying to avoid settings bloat, so its a no to this request. I don't want to have a toggle for every single little piece of info.

You can open the side menu with whatever button is mapped to the "menu" command in your keymap. On the default keyboard setup it is "M".
On remotes it depends. This command will open the side menu in any screen.


(2017-09-14, 16:38)horstepipe Wrote:
Movie view Media Info 2


I love this view for movies, here is some brainstorming which maybe would make it even better:
I think what should be tried to accomplish, is getting as less running text as possible by eliminating redundant information.
You could remove the (green marked) rating on the right, because it is already available on the (green marked) left info line. Same for the red marked infos. Maybe you find a space-saving way for the (yellow marked) watched/unwatched/set indicator, too. Then the movie titles can be way longer before they become a running text.
Another idea is to remove the brown marked title on the left (if it won't get too confusing then), so the plot would have more place. And maybe putting the whole (blue marked) section more on top, this would give even more room for the plot. When this space is freed, maybe you'd think about adding info like movie tagline (which is currently not available in any view of the skin), budget and revenue (if this is possible without slowing it down too much).

I'm pretty set on how the info displays. The skin reuses the same list layout and same info layout pretty much for every view. This consistency is so that information is always in the expected place no matter what the view type. Still, I will respond to some of your suggestions

-- The rating on the right of the list (marked in green) -- This label is not a fixed label, but rather changes dynamically depending on the sorting of the list. If you sort by duration it will show duration, sort by year it will show year and so on. Also, the rating in the list and the rating next to the imdb info are actually different. The rating in the list is whatever value is scraped to your library (this could come from imdb, or it could come from themoviedb, or it could come from an nfo file depending on settings). The value next to the imdb icon is retrieved from imdb via skin helper. Even if they are from the same source, the imdb rating provides a way to see up to date ratings. (The star rating, on the other hand, is from your library -- but if you set a user rating it will use that instead).

-- I definitely wont remove the large title -- namely because my eyes expect the title to be there. When I'm scrolling through a list, I actually use that part of the screen as my point of reference.

-- In terms of the blue marked section, no I wont be changing the spacing between elements. I have worked hard to make this consistent through out the skin (40px spacing). I have specifically approached the skin with the idea of giving space for elements to breathe. The last thing I want to do is try and cramp things together to jam more information in that is of only a passing minor interest.


Regarding budget/revenue/tagline -- I would like to incorporate these into the info screen somehow. However, I don't think this info needs to be readily available in the library view. I have specifically chosen to display the information that helps me to decide what movie to watch (ratings, duration, genre, classification, plot, end time, number of oscars). Whilst the tagline/budget/revenue is interesting, it isn't really a factor in deciding what I want to watch. I'm really quite against this notion of attempting to stuff every bit of art and info into a viewtype -- put too much stuff in and it all starts looking like a myspace or geocities page. I get the appeal of being able to see lots of different details about a movie, but there has to be some sort of balance...
Arctic Fuse 2 - Alpha now available. Support me on Ko-fi.
Reply
In Estuary it shows the Season/Episode as S00E00 when you press info on a something from pvrguide
Image

Could this be how Horizon displays it instead of how it is now or even better if you could make it S00E00 in the now playing bar instead of 0x00
EDIT: or where is says 3x10 Criminal Minds it would give the subtitle instead so 3x10 True Night
Image

Any chance the square widget could look like this for pvr
Image
Instead of
Image
Reply
@komplex - are you using latest git. Because I already pushed a change with the square widgets so the scaling shouldn't cut off the icons. Can you get latest git and confirm?

Regarding season/episode numbers the problem is that kodi hard codes some labels in the 1x01 format. There are ways around it, but it involves a lot of extra code. So I want to keep it consistent through the skin. Also with the S01E01 format there is no way for me to add the leading 0 on single digits and I only think it looks good that way. S1E1 I'm not a fan of. Plus it doesn't take into account other languages (which is why I'm guessing kodi hard codes the labels the other way)
Arctic Fuse 2 - Alpha now available. Support me on Ko-fi.
Reply
  • 1
  • 57
  • 58
  • 59(current)
  • 60
  • 61
  • 88

Logout Mark Read Team Forum Stats Members Help
Horizon - Krypton13