Posts: 7,254
Joined: May 2011
Reputation:
397
2018-01-28, 18:43
(This post was last modified: 2018-01-28, 19:10 by Lunatixz.)
Can you explain what this script is supposed to do? After evaluating the code I'm stumped... It appears to collect user moviesets from json, then set movieset details using the same meta it just received... What does this accomplish? Also can you explain the need for movieset info in a txt file?
Posts: 1,332
Joined: Jan 2016
Reputation:
54
2018-01-28, 20:39
(This post was last modified: 2018-01-28, 20:40 by smitchell6879.)
So for me using Kodi 18 nightly I rescraped my library which is well over 1000 movies in turn gave me over 200 moviesets....well Kodi may download the set art work to sets and setfanart but that is still no good in the skin yet. So this script sets the set artwork to poster and fanart so that it is actually being used by the skin... By default the poster and fanart are set to the first movies poster and fanart in the collection.
As far as the text file I am adding to it but when done it output the movies collections that where changed and will output another file that did not and have the missing artwork.... But that part isn't finished yet... I figured I would share this now even if not 100% complete just because it does the main intention of setting artwork
Posts: 1,332
Joined: Jan 2016
Reputation:
54
Also for me I want a printed out list of all the Blu-ray movies I have so that I don't buy duplicates... So I am planning on adding a option to print the entire library to a text file as well.
And figure I can expand even more in time... Or I can merge this script with the special features plugin. But I haven't thought that far ahead yet... I just wanted my artwork to show hahaha
Posts: 7,254
Joined: May 2011
Reputation:
397
I can't imagine this being ideal for most users. I would suggest you consider renaming the plug-in to something unique and descriptive and perhaps include a description that warns users this can override their artwork.
Posts: 7,254
Joined: May 2011
Reputation:
397
2018-01-29, 01:27
(This post was last modified: 2018-01-29, 01:29 by Lunatixz.)
All contributions are welcome, I was simply concerned by the code, it's execution and the lack of description/information being given to the user. Calling something a library helper when it sole operation is to override movie set meta is a little vague IMO
Posts: 1,332
Joined: Jan 2016
Reputation:
54
Well I plan to add to it in time but figure I would release it now fix the bugs before I make it to complex and get lost with simple issues that may arise.... Like me needed to add a check for the artwork and print what is actually missing versus what was done even when skipped..
But I agree and I like this name better so I may merge then code for the special features and that too is helping build a better user experience.... and if nothing else these 2 things are filling in the gaps for my library at least.
but will I have your attention.... quick question about library nodes ... what I would like to do is have a setting that would add the special features to the movies nodes.... but when playing around with the library node editor and adding the node that way I realize that it will not always show up only when I enter that subsection a certain way.... is this because of the way estuary enters the library or is something else?
I have a few ideas but personally I want better library integration as I add then I want to make them some what seem apart of the core of kodi even thou they are not. I personally don't like flipping in and out just to look at something simple if I can integrate it.
which is why I was looking at the node editor.
Posts: 1,332
Joined: Jan 2016
Reputation:
54
2018-02-01, 07:27
(This post was last modified: 2018-02-01, 07:33 by smitchell6879.)
Sure I don't mind adding this in the next time I update.
Posts: 3,212
Joined: May 2008
Reputation:
111
olympia
Team-Kodi Member
Posts: 3,212
This will be coded up in Leia eventually and artwork will be set automatically. You will also be able to choose between scraped artwork. We are adding new features which were non-existing before and indeed, it is not complete yet. But this will come and Leia is not going to be released without that, so this will only be useful and the new feature will be complete in Leia.