[beeswax]

Thanks FernetMenta, does anyone know how to translate that into actual changes in the code, personally I don't understand what he said   I see nothing in the python script referencing 'defaultRes' or 'GUIWindows'.

[FernetMenta]

Thanks FernetMenta, does anyone know how to translate that into actual changes in the code, personally I don't understand what he said   I see nothing in the python script referencing 'defaultRes' or 'GUIWindows'.

The python code uses class WindowXMLDialog

class MyClass(xbmcgui.WindowXMLDialog):

check out the constructor of this class:
https://github.com/xbmc/xbmc/blob/eb161c...XML.h#L473

cpp:


/// \python_class{ xbmcgui.WindowXMLDialog(xmlFilename, scriptPath[, defaultSkin, defaultRes]) }



class WindowXMLDialog : public WindowXML, private WindowDialogMixin

{

public:

WindowXMLDialog(const String& xmlFilename, const String& scriptPath,

const String& defaultSkin = "Default",

const String& defaultRes = "720p");

Set defaultSkin and defaultRes in the python code

[beeswax]

Thanks again FernetMenta, your input is greatly appreciated.  I've looked at the linked code and the quoted snippet and tried to figure out how that transposes onto the addon's code but my coding skills are not sufficient, I just don't get it.  Hopefully someone who knows what they're doing with Python can jump in now that we've at least pinpointed the root cause of the problem.

[scott967]

I assume he means, when the addon creates an instance of the class MyClass in line 684:

Code:

mydisplay = MyClass('cleaner-window.xml', addonpath)

to set the resolution like

Code:

mydisplay = MyClass('cleaner-window.xml', addonpath,'Default','1080p')

But I think you also need to update the skin file cleaner-window.xml

I don't use this addon, but if you want to give  a try to my fix I forked the addon to my github acct and have a fix_resolution branch with my commits.
script.database.cleaner fork

scott s.
.

[FernetMenta]

Should be 1080i

[Kib]

The original author had skinned everything in 1920x1080 but put it in a 720p folder.
Obviously the coordinates were off screen, and in order to 'correct' that he then resized everything with the 'setCoordinateResolution'.
The only thing needed to make it work properly is to rename the folder to 1080i, and remove the line with setCoordinateResolution and call the dialog properly.

I have put the changes in a branch here: https://github.com/kib/script.database.c...-reso-leia and submitted a PR to the author.

PS: Scott, you resized everything in the xml, but he already had everything in 1080
PS PS: this also works when you do not call the dialog properly, Kodi finds the 1080i folder and handles it.

[Kib]

Adding a link to the repo.zip using Add source via the File manager, then selecting Add-ons to Install from zip file method works with other repos. I’ve seen it done at a mates place with the illegit srp repo which shouldn’t be mentioned here.

 No it doesn't.

What works is adding a file source to the folder that contains the zip, and then installing it from "install from zip".
Then you can install any add-ons from the repo from the 'Install from repository' menu.

[beeswax]

The only thing needed to make it work properly is to rename the folder to 1080i, and remove the line with setCoordinateResolution and call the dialog properly.

 Fantastic!  I've just tried exactly that and it works fine again now.  The only other niggle left is I'm not sure the addon's SQL wizardry still works any more.  If I check the addon log after doing a cleanup, I see several entries have supposedly been removed from the database.  I perform a 'Clean Library' in Kodi and then run the addon again, the same 6 lines show up again in the log saying they've been removed.  So I don't think it's actually removing anything.  Anyone else seeing that?  The addon log is in %appdata%\Kodi\cache btw.

[scott967]

PS: Scott, you resized everything in the xml, but he already had everything in 1080
PS PS: this also works when you do not call the dialog properly, Kodi finds the 1080i folder and handles it.

  
[align=initial ! important]   [/align]
Thanks.  I didn't actually look at the xml (my bad) just assumed it was 720 and ran it through XBMC Skinning Tool to convert it.

scott s.
.

[black_eagle]

The original author had skinned everything in 1920x1080 but put it in a 720p folder.
Obviously the coordinates were off screen, and in order to 'correct' that he then resized everything with the 'setCoordinateResolution'.
The only thing needed to make it work properly is to rename the folder to 1080i, and remove the line with setCoordinateResolution and call the dialog properly.

I have put the changes in a branch here: https://github.com/kib/script.database.c...-reso-leia and submitted a PR to the author.

PS: Scott, you resized everything in the xml, but he already had everything in 1080
PS PS: this also works when you do not call the dialog properly, Kodi finds the 1080i folder and handles it.

Hehe, it's sure been a while !

 Thanks for that !!  Skinning was never really my thing so it was all just cobbled together really from looking at how other people had done stuff in the past.

Fantastic!  I've just tried exactly that and it works fine again now.  The only other niggle left is I'm not sure the addon's SQL wizardry still works any more.  If I check the addon log after doing a cleanup, I see several entries have supposedly been removed from the database.  I perform a 'Clean Library' in Kodi and then run the addon again, the same 6 lines show up again in the log saying they've been removed.  So I don't think it's actually removing anything.  Anyone else seeing that?  The addon log is in %appdata%\Kodi\cache btw.

Hmm, the SQL wizardry was pretty much down to @BatterPudding.  Looking over the code again, I think I'd have maybe handled things differently knowing what I do now.  It was originally written so that the SQL commands would work on both SQLite and SQL as there are some differences between the two.  In retrospect, it may have been easier (as the addon determines which type of db it's looking at) to write separate statements for both instances and then call the correct construct based on the db type it's connected to.

Although I'm still on 16.1 (for various reasons that I don't need to go into here), I did, funnily enough, clone and build 18's master branch on Friday.  My free time is much more limited than it used to be, but I'll see if I can get some cruft into it's db, then run the addon and see what, if anything, happens.

[BatterPudding]

Hehe, it's sure been a while !

Do you think anyone noticed us missing?

Hmm, the SQL wizardry was pretty much down to @BatterPudding.

I've been trying to blame you for that... hehe... My excuse is no SQL Server here, just making it up as I go along on based on specs and random tests on SQL Lite.

My free time is much more limited than it used to be

Life gets in the way too much...

[pjotr69]

" You'll find it listed under Program Addons as Video Database Cleaner. When you click Run you'll be shown the confirmation page of what will be cleaned based on your settings.. Check it looks right and then hit OK. The clean will then happen, followed by KODI's own Clean Library function.""

Does anyone know if this kind of datbase cleaner still exist?
(i have a full database and can't clean up any more.)

[black_eagle]

" You'll find it listed under Program Addons as Video Database Cleaner. When you click Run you'll be shown the confirmation page of what will be cleaned based on your settings.. Check it looks right and then hit OK. The clean will then happen, followed by KODI's own Clean Library function.""

Does anyone know if this kind of datbase cleaner still exist?
(i have a full database and can't clean up any more.)

 Yes, it still exists and was recently updated to support Kodi 18 (thanks to @Kib) !! 

You can either download the zipped file from https://github.com/the-black-eagle/scrip...se.cleaner and install (making sure 'use unknown sources' is enabled), or you can download and install the repo (https://github.com/the-black-eagle/repos...blackeagle) and then install the cleaner from there.

[pjotr69]

Thank you Black Eagle.
I will download it after i do a clean install on a bigger sd.
place a backup on that and use that for cleanup.

[pjotr69]

" You'll find it listed under Program Addons as Video Database Cleaner. When you click Run you'll be shown the confirmation page of what will be cleaned based on your settings.. Check it looks right and then hit OK. The clean will then happen, followed by KODI's own Clean Library function.""

Does anyone know if this kind of datbase cleaner still exist?
(i have a full database and can't clean up any more.)

 Yes, it still exists and was recently updated to support Kodi 18 (thanks to @Kib) !! 

You can either download the zipped file from https://github.com/the-black-eagle/scrip...se.cleaner and install (making sure 'use unknown sources' is enabled), or you can download and install the repo (https://github.com/the-black-eagle/repos...blackeagle) and then install the cleaner from there. 

 Probably my ignorance but how can i instal this addon?
Can't find your link or "database Cleaner" or even your repository.blackeagle in "install from repository"
Did enable unknown sources.