[Haris1977]

@jvandenbroek what about the “Assume as watched” option problem?

 Should be fixed in latest release.

Thanks

[Haris1977]

Just an other question: Will this addon erase the main “episode” folder too (if the last video+srt file is deleted?)

Let s say i have an A folder [in tv series] and inside those files:

A.2017.S01E01.hdtv.x264.avi and
A.2017.S01E01.hdtv.x264.srt

If this addon deletes those 2 files, will the A folder be deleted too?

[jvandenbroek]

Just an other question: Will this addon erase the main “episode” folder too (if the last video+srt file is deleted?)

Let s say i have an A folder [in tv series] and inside those files:

A.2017.S01E01.hdtv.x264.avi and
A.2017.S01E01.hdtv.x264.srt

If this addon deletes those 2 files, will the A folder be deleted too?

If there are no other files left in folder A and you've enabled 'Remove empty directories' under file management options, then yes. If that doesn't seem to work, it could be there are leftover hidden files and/or incorrect permissions.

[Haris1977]

'Remove empty directories' for TV Episodes (that's where i need it i guess and not in movies) never worked for me

I use win7 as a server with a program called haneWIN NFS Server. Here is my export sample (as y see i dont use the -readonly flag in order for the prog to be able to delete it)

https://www92.zippyshare.com/v/V9JmYeVP/file.html

I dont see any hidden files too. What could be wrong?

My example Files (but i have similar problem with all my tv series structure):

Life in the Tomb 2019/Life.In.The.Tomb.S01E01.HDTV.x264.mkv + srt

P.S Of course i can "manually" delete that folder by bringing up the contenxt menu, but i d love to see a more automated solution.

[lovemyram4x4]

There's 2 remove empty directories for episodes.

I have update library off but it still updated library.

Do you mean 2 empty directories are not deleted inside an episode folder? What is your directory structure? 

The library update option is only for enabling/disabling a full library update, it will always try to just update (clean out) the single entry. Is there a specific reason why you wouldn't want to remove the entry from database after removing the file? I could consider adding that as optional as well. Probably should have named it 'full library update' instead, seems misleading now.

Edit: Wait I forgot about the 'remove video from library' option. When you disable this, no updates should happen. 

 in the configurations settings 2 settings under tv shows for remove empty directories.

Yes, there actually is a reason I don't want it to update the single entry. I have a really large library and often watch groups of shows (chicago med/pd/fire, ncis's, etc) or just alphabetically down the shows for new shows. If it updates the single entry and there's only one show it kicks me back up to the to of the library (this is the thing I missed most about afterwatch after updating to kodi 18-I actually programmed a delete key on my remote to use while afterwatch was broken). I have another machine that takes care of library updates via watch dog.

My previous versions of afterwatch didn't the update like this one and manually deleting.

[jvandenbroek]

in the configurations settings 2 settings under tv shows for remove empty directories.

Yes, there actually is a reason I don't want it to update the single entry. I have a really large library and often watch groups of shows (chicago med/pd/fire, ncis's, etc) or just alphabetically down the shows for new shows. If it updates the single entry and there's only one show it kicks me back up to the to of the library (this is the thing I missed most about afterwatch after updating to kodi 18-I actually programmed a delete key on my remote to use while afterwatch was broken). I have another machine that takes care of library updates via watch dog.

My previous versions of afterwatch didn't the update like this one and manually deleting.

Ah i see, will remove the double entry

The issue seems related to this bug in Leia: https://github.com/xbmc/xbmc/issues/15252

The option I referred to above has disappeared because of this, so now it defaults to remove entry from db. As you can see it's being discussed and will most likely be merged before version 18.1 gets released, so that should fix this specific issue. edit: the mentioned PR is actually already merged it seems and not fixing the issue in all cases. I'll take a look at it and may reimplement this function to work around this bug.

[lovemyram4x4]

That would be awesome if you could get it to work, with how long I've been waiting for them to fix EDL functions (broke in 17 and still broken) I don't see this taking much priority either since neither prevent me from using Kodi just makes things less efficient on my end.

[jvandenbroek]

New release
1.0.5 (2019-02-11):
* Fix removing empty dir when using alt file method (forced on nfs/smb shares)
* Moved some settings from advanced to properties
* Remove video from library is now visible again under properties
* Some better error checking
* Added tv show name in confirmation dialogs
- Rating section not enabled on v18.0 (Leia) due this bug: https://github.com/xbmc/xbmc/issues/15252
  Should work again when fixed in upstream Kodi

Latest repository (recommended way of updating): https://github.com/jvandenbroek/jvandenb...-1.0.1.zip
Direct add-on download: https://github.com/jvandenbroek/jvandenb...-1.0.5.zip

[jvandenbroek]

'Remove empty directories' for TV Episodes (that's where i need it i guess and not in movies) never worked for me

I use win7 as a server with a program called haneWIN NFS Server. Here is my export sample (as y see i dont use the -readonly flag in order for the prog to be able to delete it)

https://www92.zippyshare.com/v/V9JmYeVP/file.html

I dont see any hidden files too. What could be wrong?

My example Files (but i have similar problem with all my tv series structure):

Life in the Tomb 2019/Life.In.The.Tomb.S01E01.HDTV.x264.mkv + srt

P.S Of course i can "manually" delete that folder by bringing up the contenxt menu, but i d love to see a more automated solution.

  I believe it's fixed in the last release. If still not working, please enable debug and paste the log here.

[jvandenbroek]

That would be awesome if you could get it to work, with how long I've been waiting for them to fix EDL functions (broke in 17 and still broken) I don't see this taking much priority either since neither prevent me from using Kodi just makes things less efficient on my end.

Check out the latest release, I've moved the 'remove video from library' option to properties, so it's visible again. You might need to disable this setting, after which no library updates should take place. Let me know if this works for you.

[AnonTester]

A new problem with 1.0.5,
error message in movie.py line 204 after playing a movie:
https://paste.kodi.tv/picajutivo.kodi

Also in this log, issue with the path. For whatever reason only the remote server is logged or retained and not the actual path to the file. I added a dump of j to the output for you to see what the file variable in j actually contains. Deleting didn't work with 1.0.4 either and the same was in the logs (just the main server details, not the actual file path) and deleting didn't work.

This is on Linux (Ubuntu 18.04.1 LTS) with Kodi 18.1-RC1 Git:20190211-1c60cbd

[AnonTester]

problem is the xbmc.validatePath call in line 25 which strips the rest of the path.

Description of what validatePath does here and it doesn't appear that this is a particularly useful function:
https://alwinesch.github.io/group__pytho...f791d22c44

[Haris1977]

I get the next debug error when the 1.0.5 addon tries to delete a movie (but it seems that it can delete my Tv Episodes though):

%d format: a nunmber is required, not str

[jvandenbroek]

Will fix tonight, I need to test movies more

[Haris1977]

Thanks.

I 've just seen an other error too: While i get the delete notification (in tv episodes) when i hit delete - > yes nothing happens (tv episode is not deleted)

(i should have tested that before)