[jndbfjgnfjh5423]

I have a custom keymap that opens smart playlists. Since updating to Leia these don’t work correctly. Kodi recognises the key press and places the playlist into the music queue but nothing is played. If I browse to the smart playlists, I can manually play/queue them without issue.

https://paste.osmc.tv/urejodosit

In the log above I press F4 to open my Electronic smart playlist but it fails to produce any music.

My keymap is as follows (F1-F6 no longer work, but everything else is fine):

xml:


    <keymap>

            <global>

                    <keyboard>

                            <v mod="ctrl">CodecInfo</v>

                            <u mod="ctrl">NextSubtitle</u>

                            <d mod="ctrl">Info</d>

                            <c mod="ctrl">ContextMenu</c>

                            <m mod="ctrl">ActivateWindow(visualisation)</m>

                            <g mod="ctrl">ActivateWindow(music,Albums)</g>

                            <f1>PlayMedia(/home/osmc/.kodi/userdata/playlists/music/jazz.xsp)</f1>

                            <f2>PlayMedia(/home/osmc/.kodi/userdata/playlists/music/folk.xsp)</f2>

                            <f3>PlayMedia(/home/osmc/.kodi/userdata/playlists/music/blues.xsp)</f3>

                            <f4>PlayMedia(/home/osmc/.kodi/userdata/playlists/music/electronic.xsp)</f4>

                            <f5>PlayMedia(/home/osmc/.kodi/userdata/playlists/music/hiphop.xsp)</f5>

                            <f6>PlayMedia(/home/osmc/.kodi/userdata/playlists/music/musical.xsp)</f6>

                            <f7>PlayerControl(Partymode(music))</f7>

                            <four mod="meta">PlayMedia(plugin://plugin.audio.radio_de/station/3243)</four> <!-- BBC Radio 1 -->

                            <five mod="meta">PlayMedia(plugin://plugin.audio.radio_de/station/3244)</five> <!-- BBC Radio 2 -->

                            <six mod="meta">PlayMedia(plugin://plugin.audio.radio_de/station/4938)</six> <!-- RNE Radio 3 -->

                            <seven mod="meta">PlayMedia(plugin://plugin.audio.radio_de/station/10988)</seven> <!-- M80 Radio -->

                    </keyboard>

            </global>

            <FullscreenVideo>

                    <keyboard>

                            <x mod="ctrl">ActivateWindow(subtitlesearch)</x>

                    </keyboard>

            </FullscreenVideo>

    </keymap>

[jndbfjgnfjh5423]

Any ideas? @Klojum ?

[DaveBlake]

I have just had a quick look, and I can reproduce your issue @jndbfjgnfjh5423 (on Win10 so not platform specific). I need some more time to dig into what is happening and make comparisons with v17 etc.

Out of interest,  with a limited random playlist of albums what would you expect to see played
a) all the songs in order from 16 random albums with songs of a certain genre
b) 16 random songs with that genre

When I browse the smart playlist I see 16 albums listed, and if I hit play from the list of playlists a) gets added to the current player queue. But when I playthe smartplaylist via the  "playmedia" builtin e.g. a keymap,  it is b) that gets put on the queue. Unexpected.

EDIT:
In v17 it is always a), seems you have found a nice v18 bug for me to fix.

The Playmedia builtin is not fully unpacking the xsp into songs in the way that the media window does, and the player does not understand the list of things it is given. Once again we fall foul of the numerous routes taken through the code to play something depending on the way playback is requested. Changes made for v18, and one of the routes is negatively impacted but goes unnoticed for a while. This diversity is a major longstanding design flaw, fixing might mean actually unscrambling all of that once and for all!  Well for music anyway.

[jndbfjgnfjh5423]

Thanks for the response - I'm glad you've been able to reproduce the issue. You are correct that on a remote press I am expecting a) all the songs in order from 16 random albums with songs of a certain genre.

[DaveBlake]

Just to say I have raised a PR to fix this issue https://github.com/xbmc/xbmc/pull/16327 which I hope I can backport to v18.4 (if the team decide to do that as a point release).

[jndbfjgnfjh5423]

Just to say I have raised a PR to fix this issue https://github.com/xbmc/xbmc/pull/16327 which I hope I can backport to v18.4 (if the team decide to do that as a point release).

That's great, thank you. Looking forward to the next release with your fix.

[jndbfjgnfjh5423]

Just to say I have raised a PR to fix this issue https://github.com/xbmc/xbmc/pull/16327 which I hope I can backport to v18.4 (if the team decide to do that as a point release).

@DaveBlake I'm not familiar with GitHub's pull system, however, the request is labelled as backport:done but I don't see PlayerBuiltins.cpp changed in master or Leia. Is that normal?

[DaveBlake]

The key thing to look for is if either PR (on master or the backport to v18) have been merged. They haven't because no one has reviewed, but I have hit the button now. It was tested, and unlikely to get any other input. Once merged it will appear in  future test builds.