[sualfred]

@nessus 
Please check the editor again. I've changed a lot and added a new context menu with new options. I need more testings with the .nfo writing, etc.

Note: nfo gets written after the editor has been closed to reduce the amount of file accessing.

[bsoriano]

@sualfred , I have been testing the metadata editor script, thank you for this! I have tested both from a button in the skin and from the context menu.  In both scenarios the script works well for movies.  I have not had any issue saving info back to the nfo files (which is really important in my case, as I only use local scraping from NFOs).  Again, thanks a lot for this!

Regards,

Bart

EDIT: @sualfred , Once I started testing with tv shows, I am getting the following error when I try to edit the metadata for an episode:

xml:


2019-11-06 15:47:57.788 T:17940   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!

                                            Error Type: <type 'exceptions.UnboundLocalError'>

                                            Error Contents: local variable 'ratings_default' referenced before assignment

                                            Traceback (most recent call last):

                                              File "C:\Users\bsori\AppData\Roaming\Kodi\addons\script.metadata.editor\default.py", line 32, in <module>

                                                Main()

                                              File "C:\Users\bsori\AppData\Roaming\Kodi\addons\script.metadata.editor\default.py", line 15, in __init__

                                                EditDialog(self.params)

                                              File "C:\Users\bsori\AppData\Roaming\Kodi\addons\script.metadata.editor\resources\lib\dialog_metadata.py", line 35, in __init__

                                                self.init()

                                              File "C:\Users\bsori\AppData\Roaming\Kodi\addons\script.metadata.editor\resources\lib\dialog_metadata.py", line 47, in init

                                                self.generate_list()

                                              File "C:\Users\bsori\AppData\Roaming\Kodi\addons\script.metadata.editor\resources\lib\dialog_metadata.py", line 214, in generate_list

                                                if ratings_default:

                                            UnboundLocalError: local variable 'ratings_default' referenced before assignment

                                            -->End of Python script error report<--

I am also getting that error for tv shows, but not always.  I did notice that for all tv shows I tried, the field  "status" always showed "value could not be fetched".

Please let me know if you need additional info.  Thanks.

[sualfred]

Can you provide me your videodb file and let me know which tvshows are causing the issue?
As far as I understand Kodi correctly all video items have the ratings table now but I'm not sure.

The "status" valued is not returned by Kodi. I can set it but no way for me to get the value that is stored.

[bsoriano]

Can you provide me your videodb file and let me know which tvshows are causing the issue?
As far as I understand Kodi correctly all video items have the ratings table now but I'm not sure.

The "status" valued is not returned by Kodi. I can set it but no way for me to get the value that is stored.

@sualfred , I sent you a PM with a link to my video db file.  You can see the issue for example with tv show Batwoman.  After looking further, it seems that any item which does not have a rating in the video db causes the script exception, whether it is a tv show or episode (all of my movies have a rating from IMDB).  The vast majority of my episodes does not have a rating in my videodb, and many of my tv shows do not have one either.  The script works fine for my tv shows that have a tvdb rating in the video db.  You can see this with tv show The Good Doctor, for example.

Don't worry about the status field.  The field is empty in most of the NFOs for my tv shows.

Please let me know if you need additional info.  Thanks.

Regards,

Bart

[sualfred]

Thanks. Should be fixed now.

[bsoriano]

Thanks. Should be fixed now.

@sualfred , indeed it is fixed, thanks a lot.

Regards,

Bart

[bsoriano]

@sualfred , would you consider writing back to the NFO the year from the premiered/released date in the <year> tag? Thanks.

Regards,

Bart

[sualfred]

Year tag deprecated. It is ignored by Kodi. Does your .nfo editor read this tag?

[bsoriano]

Year tag deprecated. It is ignored by Kodi. Does your .nfo editor read this tag?

@sualfred , I did not know that, thanks.  I use Media Companion to scrape information and create the NFOs, and it populates that tag.

Regards,

Bart

[sualfred]

Anyway, to be sure I've added it.

[bsoriano]

Anyway, to be sure I've added it.

Thanks!

Regards,

Bart

[sualfred]

Script has its own thread now:
https://forum.kodi.tv/showthread.php?tid=349035

[bsoriano]

@sualfred, I updated the embuary helper script to the latest Git version today, and I am getting the following error in the log when Kodi starts:

xml:


2019-11-11 16:56:46.189 T:12692   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!

                                            Error Type: <type 'exceptions.ImportError'>

                                            Error Contents: No module named context

                                            Traceback (most recent call last):

                                              File "C:\Users\bsori\AppData\Roaming\Kodi\addons\script.embuary.helper\service.py", line 6, in <module>

                                                from resources.lib.service_monitor import *

                                              File "C:\Users\bsori\AppData\Roaming\Kodi\addons\script.embuary.helper\resources\lib\service_monitor.py", line 12, in <module>

                                                from resources.lib.utils import split

                                              File "C:\Users\bsori\AppData\Roaming\Kodi\addons\script.embuary.helper\resources\lib\utils.py", line 21, in <module>

                                                from resources.lib.context import *

                                            ImportError: No module named context

                                            -->End of Python script error report<--

Please let me know if you need any additional info.  Thanks.

Regards,

Bart

[sualfred]

Ups, forgot these. Strange why I haven't faced this exception.
Anyway, update is on the repo.

[bsoriano]

Ups, forgot these. Strange why I haven't faced this exception.
Anyway, update is on the repo.

@sualfred, thanks! I confirm the issue is fixed.

Regards,

Bart