[patzzz]

Thanks @sualfred, one question about the new changes:

- Season dialog fixed: Wrong containers got filled. Check readme for the correct IDs

What was the problem with Season dialogs and wrong containers IDs?
Have you changed the IDs?

Although it isn't related to the new version, I've detected a bug using the exact search with TV Shows and year.
For example, this exact search isn't returning any results:

Code:

RunScript(script.embuary.info,call=tv,query=Vikings,year=2013,exact=true)

but it should return a result.

The bug with the exact search is because it's using the 'release_date' field, but TV Shows need to search using 'first_air_date' (line using 'release_date' in the exact search).

Could you fix this bug?
Thank you.

[sualfred]

@patzzz 

Thanks, please check https://github.com/sualfred/script.embua...81fa63ab65 for the exact issue

I haven't changed the IDs but with a cleanup in the past I've introduced a bug where the guest stars and images were filled to wrong containers. The readme was always correct.

[patzzz]

Thanks @sualfred, the exact search bug is now fixed.

[bsoriano]

@sualfred , thank you for adding a next aired function to embuary.info.  I am just now testing this (browsing the addon itself) and I found two issues:

1. It seems the days are shifted 1 day.  For example, all of the shows the addon says are airing on Monday, March 2nd, are really airing on Sunday, March 1st.  And so on, Tuesday's are actually Monday's, etc.

2. Not all of my shows are showing up.  For example for today, Sunday March 1st (the addon would say it is airing on Monday, I guess), the addon is not showing The Outsider (2020).  I checked in tvdb and episode 9 of that tv show is airing today (tvdb id for the show is 365480).  The episode is also showing as airing today in trakt.tv.

I am thinking of replacing tv.show.next.aired with embuary.info, and was wondering, what listitem property is the weekday the episode is airing? Also, would you consider adding the network (perhaps as listitem.studio) that the episode has in thetvdb? Also, any particular reason why the listitem.dbtype returned is video and not episode?

I am testing the addon with the latest Matrix nightly running under Windows 10.  Please let me know if there is any additional info you would like me to send you.  Thanks.


Regards,

Bart

[sualfred]

It's wip, but thanks for the feedback. 

I use the date trakt is returning. Maybe it was caused by the 29th Feb? ^^ Check it again please.

Does The Outsider have a tvdb/tmdb/imdb stored at your end?

[bsoriano]

It's wip, but thanks for the feedback. 

I use the date trakt is returning. Maybe it was caused by the 29th Feb? ^^ Check it again please.

Does The Outsider have a tvdb/tmdb/imdb stored at your end?

@sualfred, I checked again, the dates are still shifted one day.  

The Outsider has both tvdb (default) and imdb id's sotred at my end.

Please let me know if there is any additional info that you would like me to send you.  Thanks.

Regards,

Bart

[sualfred]

Does the premiered date value fit to the day? Because it does on my end.

Can you upload me your myvideo db to see why outsider isn't recognized?

[bsoriano]

Does the premiered date value fit to the day? Because it does on my end.

Can you upload me your myvideo db to see why outsider isn't recognized?

@sualfred, as soon as I get back to my test system I will check the premiered date and upload my videodb. I think it might be a time zone issue? I am on Atlantic Standard Time with no daylight savings. I know something similar happened with tmdb helper and jurialmunkey had to fix something to do with time zones in his code.

Regards,

Bart

[sualfred]

Ah, okay. That would make sense. I currently just convert the airing time, not the day. All airing dates are in UTC. And Atlantic Standard Time has -4h.

Will take care of it as soon as I find some time. Just became a father for the second time 4 days ago which has a higher priority atm. Give me a couple of days.

[bsoriano]

Ah, okay. That would make sense. I currently just convert the airing time, not the day. All airing dates are in UTC. And Atlantic Standard Time has -4h.

Will take care of it as soon as I find some time. Just became a father for the second time 4 days ago which has a higher priority atm. Give me a couple of days.

@sualfred, congratulations!!!!😊

Take all the time that you need.

Regards,

Bart

[sualfred]

@bsoriano 

Thanks.

Had a few minutes while I was giving the bottle. Can you check if the dayoffset issue is gone? It's possible that you have to disable the caching or delete the simplecache.db.

[bsoriano]

@bsoriano 

Thanks.

Had a few minutes while I was giving the bottle. Can you check if the dayoffset issue is gone? It's possible that you have to disable the caching or delete the simplecache.db.

@sualfred, thanks! The issue is fixed.  I am not getting all of the episodes that are airing each day, but I have not found a pattern yet.  I will make sure all of my tv shows have a unique tvdb/imdb/tmdb id and will test again.  For example, the only episode I should be getting for today, Tuesday, March 3rd is episode 11 of season 6 of Empire, but it is not showing up.

As soon as I ensure all of my tv shows have a valid uniqueid, I will test.  If there are still shows not showing up, I will upload my videodb so that you can take a look.

Again, thanks!

Regards,

Bart

[sualfred]

@bsoriano 
I've added another check for a matching TV show title + release year.

[bsoriano]

@bsoriano 
I've added another check for a matching TV show title + release year.

@sualfred, definitely better! Now I get Empire for today.  I am not getting Lego Masters (US) and 68 Whiskey tomorrow, but I am not sure if those are due to any issue of ids on my end.  I will need to test once I have updated all of the ids.  It is taking a bit because I have over 700 shows.

Regards,

Bart

[sualfred]

Ok, that's everything I can do from my side. My approach needs a matching ID (tvdb, tmdb, imdb) or a matching local<->trakt show title + release year.