Posts: 15,282
Joined: Jan 2009
Reputation:
739
ronie
Team-Kodi Member
Posts: 15,282
yup, i was able to reproduce those crashes.
i don't see how it's related to this addon though?
Posts: 5,483
Joined: Jul 2012
Reputation:
385
Yes, I was being kind of lazy. But more directly, this addon could be alerted to skinners as well as addon devs.
scott s.
.
Posts: 5,483
Joined: Jul 2012
Reputation:
385
2018-06-17, 07:59
(This post was last modified: 2018-06-17, 08:00 by scott967.)
Good find. So I was looking at xbmc/repo-resources and see the most recent bad commit for Leia branch was 14 May for Greek strings #22004 and #22005. I found the problem in Croatian where {0:s} was replaced by {0:d}. That one is bit more insidious as the syntax is correct. I don't know how transifex works, but it seems there needs to be some QA on how formatting codes in translated strings are handled before commits are merged. I checked out the repo Leia branch locally so I could grep some files and didn't see any other obvious bugs, but that was kind of a visual inspection with a simple regex search and not really a 100% method. So maybe with Croatian and Greek I just happened to install the only two bugged string.po files. Anyway fixing the substitution/formatting codes in those two languages resolved the crashes.
scott s.
Posts: 35
Joined: Mar 2016
Reputation:
0
thank you guys that was really helpful!
Posts: 1
Joined: Jan 2018
Reputation:
0
2018-12-17, 14:52
(This post was last modified: 2018-12-17, 14:55 by Iwojimy.)
Well, June is far away, but crashing Kodi 18 is still here! At least for Croatian language.
If you install Croatian language everything seems fine until you try to change skin. Than Kodi 18 will crash.
In file strings.po:
C:\Users\name_user\AppData\Roaming\Kodi\addons\resource.language.hr_hr\resources\strings.po
change { 0 : d } in { 0 : s } (without spaces) on lines:
1610
1974
2038
That works for me.
While you are here you can delete unnecessery "%d" on line 12750.
Posts: 5,483
Joined: Jul 2012
Reputation:
385
Thanks for some reason I thought this was fixed. I was recently added as a "translator" for Croatian, but I can only offer "suggestions" and upvote previous suggested changes (2 already were in transiflex as suggestions). Hopefully these can be accepted (I admit, I don't know the approval process for these, but at least the needed changes are now documented in the system).
scott s.
.
Posts: 117
Joined: Nov 2010
Reputation:
2
2020-03-04, 20:14
(This post was last modified: 2020-03-05, 02:40 by Karellen.
Edit Reason: disable smilies
)
Sorry for bringing this old thread back but I had the same crash problem today while testing some skins in my native language (greek). When trying to load the skin Aeon MQ8, or Aeon Silvo immediattely after changing the language to greek , kodi crashed and it wont start again! I had to clear data and start from scrach again.
Thanks to the post above I checked the strings.po file of greek language and I found the error! It is in the line 4930 and the {0:s} string must be changed to {0:d} .
Please , any moderator, push this correction to the translation project , as I don't know how to do it...
Thank you very much all of you for the effort you put on KODI!
Posts: 12,639
Joined: Oct 2014
Reputation:
631
Thread moved to languages and translations. Hopefully the relevant people can see it here.