[jokero009]

Please read my penultimate message, I corrected it ..)

[Aaiemron]

thumb images not working looks horrible as black.
those with low thumb images I am on 4k very large TV use TMM to scrap for better images
attached video how it looks at the moment to prior update.

TMM has indeed higher quality thumbs. Thanks for the tip.

[jokero009]

I am watching a movie and probably this is the reason that the "Play" button is not visible in DialogVideoinfo..)

[jokero009]

I will return to the previous update for now .. And now the "Play" button is gone (

[heppen]

I am watching a movie and probably this is the reason that the "Play" button is not visible in DialogVideoinfo..)

Please stop a movie
Also please re-download zip file from link I sent you before. I re-enabled play button for everything and test if it will works.

[jokero009]

I turned off the movie for a while and downloaded the file again) And now the button for the TV show is not working again as before , but for movies this button is working .. And for movies there was a button "Browse", which should be only for TV show

[heppen]

I turned off the movie for a while and downloaded the file again) And now the button for the TV show is not working again as before , but for movies this button is working .. And for movies there was a button "Browse", which should be only for TV show

I know about this Ok, never mind. Please re-download zip. I made an "ultimate" change and I think now everything should be ok
Sorry for bothering you

[jokero009]

It's OK I'm just happy to help .. But I don't understand what was wrong with DialogVideoinfo?) It's just that this button worked for me without any problems after your yesterday's update .. Now I downloaded and the problem with the button for the TV show is the same (She  not working(

[heppen]

It's OK I'm just happy to help .. But I don't understand what was wrong with DialogVideoinfo?) It's just that this button worked for me without any problems after your yesterday's update .. Now I downloaded and the problem with the button for the TV show is the same (She  not working(

It was broken. As it was work ok when you was in DialogVideoInfo without digging deep it worked but when you was in DialogVideoInfo and came for example from recommended movies or similar, it crashed when you tried to play something. Same thing happened to trailer. So I had to re-implement it. I hope you understand
Ok, back to the topic.
As I understand you are trying to open TV Shows from local files right? Or you are using something like TMDb Helper?

[heppen]

Ok, I'm back with little change. Please download this zip file: https://github.com/nfm886/skin.arctic.ze...s/main.zip
Now it must work, I won't believe if not ^^

[jokero009]

I have not tried to select the recommended movies in DialogVideoInfo and, perhaps, I didn’t even notice such problems .. As for the TV show, I choose the local TV show media library) And with the review button, it doesn’t go into the episodes again, but just as it doesn’t show anything before(

[jokero009]

It also does not work with TV show episodes (I would like to send you the version in which it works great But I don't know how(

[andash]

Thanks, just pushed and update. Hope this time I did not broke too many things^^
Sorry again.

You are fast. Thanks a lot.

Hey,
I think I will bring back previous behavior on landscape art since it breaks some arts for example that one from YouTube.
Yesterday I was kind of tired to check it out but I found that, when you set Skin Settings > Library > Landscape art to true it will have similar behavior to that one we changed yesterday.
Would you like to test it out? If it's what you want I will bring back landscape arts to default with today's update.
If it not works as you want I will try to implement it in different way

Hi, I can see what's wrong with this approach now.

I only want this behaviour for small landscape view type, but changing this would be for all.

I think I found a solution.

add this this "Includes_Images.xml"

xml:
    <variable name="Image_Landscape_Small">

        <value condition="!String.IsEmpty(ListItem.Art(thumb)) + [String.IsEqual(ListItem.DBType,episode) | String.IsEqual(ListItem.DBType,video)] + String.IsEmpty(ListItem.Property(airday))+ !String.IsEqual(ListItem.Art(thumb),ListItem.Art(fanart))">$INFO[ListItem.Art(thumb)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(snap))">$INFO[ListItem.Art(snap)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[ListItem.Art(landscape)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(tvshow.landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[ListItem.Art(tvshow.landscape)]</value>

        <value condition="!String.IsEmpty(ListItem.Property(fanart))">$INFO[ListItem.Property(fanart)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(fanart))">$INFO[ListItem.Art(fanart)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(tvshow.fanart))">$INFO[ListItem.Art(tvshow.fanart)]</value>

        <value condition="!String.IsEmpty(ListItem.Thumb)">$INFO[ListItem.Thumb]</value>

        <value condition="!String.IsEmpty(ListItem.Art(thumb))">$INFO[ListItem.Art(tvshow.landscape)]</value>

        <value condition="!String.IsEmpty(Container.Art(landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[Container.Art(landscape)]</value>

        <value condition="!String.IsEmpty(Container.Art(tvshow.landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[Container.Art(tvshow.landscape)]</value>

        <value condition="!String.IsEmpty(Container.Property(fanart))">$INFO[Container.Property(fanart)]</value>

        <value condition="!String.IsEmpty(Container.Art(fanart))">$INFO[Container.Art(fanart)]</value>

        <value condition="!String.IsEmpty(Container.Art(tvshow.fanart))">$INFO[Container.Art(tvshow.fanart)]</value>

        <value condition="!String.IsEmpty(Container.Thumb)">$INFO[Container.Thumb]</value>

        <value condition="!String.IsEmpty(Container.Art(thumb))">$INFO[Container.Art(thumb)]</value>

        <value>$INFO[ListItem.Icon]</value>

    </variable>

And change line 380 and 392 in Includes_Objects.xml from 

xml:
<param name="icon" value="$VAR[Image_Landscape]" />

to 

xml:
<param name="icon" value="$VAR[Image_Landscape_Small]" />

This should also keep episode images intact and take into account the use fanart option

[heppen]

You are fast. Thanks a lot.

Hey,
I think I will bring back previous behavior on landscape art since it breaks some arts for example that one from YouTube.
Yesterday I was kind of tired to check it out but I found that, when you set Skin Settings > Library > Landscape art to true it will have similar behavior to that one we changed yesterday.
Would you like to test it out? If it's what you want I will bring back landscape arts to default with today's update.
If it not works as you want I will try to implement it in different way

Hi, I can see what's wrong with this approach now.

I only want this behaviour for small landscape view type, but changing this would be for all.

I think I found a solution.

add this this "Includes_Images.xml"

xml:
    <variable name="Image_Landscape_Small">

        <value condition="!String.IsEmpty(ListItem.Art(thumb)) + [String.IsEqual(ListItem.DBType,episode) | String.IsEqual(ListItem.DBType,video)] + String.IsEmpty(ListItem.Property(airday))+ !String.IsEqual(ListItem.Art(thumb),ListItem.Art(fanart))">$INFO[ListItem.Art(thumb)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(snap))">$INFO[ListItem.Art(snap)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[ListItem.Art(landscape)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(tvshow.landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[ListItem.Art(tvshow.landscape)]</value>

        <value condition="!String.IsEmpty(ListItem.Property(fanart))">$INFO[ListItem.Property(fanart)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(fanart))">$INFO[ListItem.Art(fanart)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(tvshow.fanart))">$INFO[ListItem.Art(tvshow.fanart)]</value>

        <value condition="!String.IsEmpty(ListItem.Thumb)">$INFO[ListItem.Thumb]</value>

        <value condition="!String.IsEmpty(ListItem.Art(thumb))">$INFO[ListItem.Art(tvshow.landscape)]</value>

        <value condition="!String.IsEmpty(Container.Art(landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[Container.Art(landscape)]</value>

        <value condition="!String.IsEmpty(Container.Art(tvshow.landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[Container.Art(tvshow.landscape)]</value>

        <value condition="!String.IsEmpty(Container.Property(fanart))">$INFO[Container.Property(fanart)]</value>

        <value condition="!String.IsEmpty(Container.Art(fanart))">$INFO[Container.Art(fanart)]</value>

        <value condition="!String.IsEmpty(Container.Art(tvshow.fanart))">$INFO[Container.Art(tvshow.fanart)]</value>

        <value condition="!String.IsEmpty(Container.Thumb)">$INFO[Container.Thumb]</value>

        <value condition="!String.IsEmpty(Container.Art(thumb))">$INFO[Container.Art(thumb)]</value>

        <value>$INFO[ListItem.Icon]</value>

    </variable>

And change line 380 and 392 in Includes_Objects.xml from 

xml:
<param name="icon" value="$VAR[Image_Landscape]" />

to 

xml:
<param name="icon" value="$VAR[Image_Landscape_Small]" />

Oki, thanks! I will add this.

[heppen]

You are fast. Thanks a lot.

Hey,
I think I will bring back previous behavior on landscape art since it breaks some arts for example that one from YouTube.
Yesterday I was kind of tired to check it out but I found that, when you set Skin Settings > Library > Landscape art to true it will have similar behavior to that one we changed yesterday.
Would you like to test it out? If it's what you want I will bring back landscape arts to default with today's update.
If it not works as you want I will try to implement it in different way

Hi, I can see what's wrong with this approach now.

I only want this behaviour for small landscape view type, but changing this would be for all.

I think I found a solution.

add this this "Includes_Images.xml"

xml:
    <variable name="Image_Landscape_Small">

        <value condition="!String.IsEmpty(ListItem.Art(thumb)) + [String.IsEqual(ListItem.DBType,episode) | String.IsEqual(ListItem.DBType,video)] + String.IsEmpty(ListItem.Property(airday))+ !String.IsEqual(ListItem.Art(thumb),ListItem.Art(fanart))">$INFO[ListItem.Art(thumb)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(snap))">$INFO[ListItem.Art(snap)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[ListItem.Art(landscape)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(tvshow.landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[ListItem.Art(tvshow.landscape)]</value>

        <value condition="!String.IsEmpty(ListItem.Property(fanart))">$INFO[ListItem.Property(fanart)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(fanart))">$INFO[ListItem.Art(fanart)]</value>

        <value condition="!String.IsEmpty(ListItem.Art(tvshow.fanart))">$INFO[ListItem.Art(tvshow.fanart)]</value>

        <value condition="!String.IsEmpty(ListItem.Thumb)">$INFO[ListItem.Thumb]</value>

        <value condition="!String.IsEmpty(ListItem.Art(thumb))">$INFO[ListItem.Art(tvshow.landscape)]</value>

        <value condition="!String.IsEmpty(Container.Art(landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[Container.Art(landscape)]</value>

        <value condition="!String.IsEmpty(Container.Art(tvshow.landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[Container.Art(tvshow.landscape)]</value>

        <value condition="!String.IsEmpty(Container.Property(fanart))">$INFO[Container.Property(fanart)]</value>

        <value condition="!String.IsEmpty(Container.Art(fanart))">$INFO[Container.Art(fanart)]</value>

        <value condition="!String.IsEmpty(Container.Art(tvshow.fanart))">$INFO[Container.Art(tvshow.fanart)]</value>

        <value condition="!String.IsEmpty(Container.Thumb)">$INFO[Container.Thumb]</value>

        <value condition="!String.IsEmpty(Container.Art(thumb))">$INFO[Container.Art(thumb)]</value>

        <value>$INFO[ListItem.Icon]</value>

    </variable>

And change line 380 and 392 in Includes_Objects.xml from 

xml:
<param name="icon" value="$VAR[Image_Landscape]" />

to 

xml:
<param name="icon" value="$VAR[Image_Landscape_Small]" />

This should also keep episode images intact and take into account the use fanart option

Ok, changes are commited. You can test it if you want now by downloading zip file from main branch. I will probably push an update tomorrow.