[ohmy]

Haven't found any official documentation on this, this was just an observation. For a length of 30 seconds $INFO[ListItem.Duration] returns 00:30, for 30 minutes it's 30:00 and for 3 hours it is 03:00:00.

Multiplying by 60 did the trick. The length of 51 minutes is now correctly stored in myvideos.db as 3060 seconds and displayed in the skin as 51:00.
Thanks again for your effort.

[shedrock]

I am not posting this for support, but rather in response to the following POST. I can say that I've encountered at least 10-20 TV Shows that TMDB did not scrape in the past, and this was even before Matrix. I cannot remember specifically which TV series did not scan, but it was so frustrating that I had to give up in the end. Quite a number of them were older TV series. I do remember a lot being British dramas. If I eventually upgrade my system (hopefully soon) to use Matrix, I'll be happy to report back a complete list, and I'll do the same for the TMDB Movie scraper as well, in the appropriate forum of course.

Regards,

Shedrock

[D-m-x]

Just an FYI that there is a release coming soon to fix the IMDB ratings (IMDB updated their web site, which broke the HTML scrape to get the ratings).  Special thanks to gumida for reporting this and submitting a patch to fix it.  Please note this fix will be available for Matrix only. No further updates are being done for Leia.

Hi @pkscout,

I know this post is almost a year old but I installed this yesterday on Leia and tried for half an hour why IMDb ratings are not working until I found this. Explains it pretty well I guess 😁

Question: Since the fix seems easy https://github.com/xbmc/metadata.tvshows...489dcc2bb2 is it possible to just edit the lib file at runtime in the add-ons folder + reboot for Kodi to pick it up? Or wouldn't this work? I'm mainly asking because there's also a .pyo file I'm the same folder.

Thanks, appreciate any answer 😄

[pkscout]

Just an FYI that there is a release coming soon to fix the IMDB ratings (IMDB updated their web site, which broke the HTML scrape to get the ratings).  Special thanks to gumida for reporting this and submitting a patch to fix it.  Please note this fix will be available for Matrix only. No further updates are being done for Leia.

Hi @pkscout,

I know this post is almost a year old but I installed this yesterday on Leia and tried for half an hour why IMDb ratings are not working until I found this. Explains it pretty well I guess 😁

Question: Since the fix seems easy https://github.com/xbmc/metadata.tvshows...489dcc2bb2 is it possible to just edit the lib file at runtime in the add-ons folder + reboot for Kodi to pick it up? Or wouldn't this work? I'm mainly asking because there's also a .pyo file I'm the same folder.

Thanks, appreciate any answer 😄

The .pyo will be regenerated if the .py file changes, so changing the .py should be fine.  You can also delete the .pyo files if you want to be double sure.  And since there won't be any updates for Leia, your change won't ever get overwritten.

[D-m-x]

Thank you, really appreciate you taking the time to answer! I deleted the .pyo as well to be sure.

That was the plan actually, no update no changes

[monisriz]

@pkscout Just switched to this scraper and was doing some test runs before scraping the actual library. Noticed an issue when trying to get tv show logos from TMDB. I think there's a missing check for image_type in set_show_artwork() function.

python:


elif image_type == 'logos':

  destination = 'clearlogo'

Did a quick test with the above change and it seems to work and the logos from TMDB show up under 'clearlogos' when going to "Choose Art". Without the above change the TMDB logos only show up if you whitelist "logos" in TV artwork settings but I don't think the logos would work since Kodi is looking for clearlogo.png and not logos.png. Used with Artwork Dump the saved file is also named as logos.png.

Secondly, TMDB logos section sometimes also have *.svg logos. From what I know Kodi doesn't accept SVGs and only works with PNGs. So a file type check is probably needed to weed out those SVGs. For example, TMDB has a SVG only and Fanart has PNG then choose the logo from Fanart instead. Or if TMDB has SVG and PNG both then choose PNG and disregard SVG.

[pkscout]

@pkscout Just switched to this scraper and was doing some test runs before scraping the actual library. Noticed an issue when trying to get tv show logos from TMDB. I think there's a missing check for image_type in set_show_artwork() function.

python:


elif image_type == 'logos':

  destination = 'clearlogo'

Did a quick test with the above change and it seems to work and the logos from TMDB show up under 'clearlogos' when going to "Choose Art". Without the above change the TMDB logos only show up if you whitelist "logos" in TV artwork settings but I don't think the logos would work since Kodi is looking for clearlogo.png and not logos.png. Used with Artwork Dump the saved file is also named as logos.png.

Secondly, TMDB logos section sometimes also have *.svg logos. From what I know Kodi doesn't accept SVGs and only works with PNGs. So a file type check is probably needed to weed out those SVGs. For example, TMDB has a SVG only and Fanart has PNG then choose the logo from Fanart instead. Or if TMDB has SVG and PNG both then choose PNG and disregard SVG.

I'll find some time to fix the logo destination and then take a deeper look at the SVG thing.

[monisriz]

@pkscout Just switched to this scraper and was doing some test runs before scraping the actual library. Noticed an issue when trying to get tv show logos from TMDB. I think there's a missing check for image_type in set_show_artwork() function.

python:


elif image_type == 'logos':

  destination = 'clearlogo'

Did a quick test with the above change and it seems to work and the logos from TMDB show up under 'clearlogos' when going to "Choose Art". Without the above change the TMDB logos only show up if you whitelist "logos" in TV artwork settings but I don't think the logos would work since Kodi is looking for clearlogo.png and not logos.png. Used with Artwork Dump the saved file is also named as logos.png.

Secondly, TMDB logos section sometimes also have *.svg logos. From what I know Kodi doesn't accept SVGs and only works with PNGs. So a file type check is probably needed to weed out those SVGs. For example, TMDB has a SVG only and Fanart has PNG then choose the logo from Fanart instead. Or if TMDB has SVG and PNG both then choose PNG and disregard SVG.

I'll find some time to fix the logo destination and then take a deeper look at the SVG thing.

Here's the PR for the change discussed above.
https://github.com/xbmc/metadata.tvshows...on/pull/83

[pkscout]

@pkscout Just switched to this scraper and was doing some test runs before scraping the actual library. Noticed an issue when trying to get tv show logos from TMDB. I think there's a missing check for image_type in set_show_artwork() function.

python:


elif image_type == 'logos':

  destination = 'clearlogo'

Did a quick test with the above change and it seems to work and the logos from TMDB show up under 'clearlogos' when going to "Choose Art". Without the above change the TMDB logos only show up if you whitelist "logos" in TV artwork settings but I don't think the logos would work since Kodi is looking for clearlogo.png and not logos.png. Used with Artwork Dump the saved file is also named as logos.png.

Secondly, TMDB logos section sometimes also have *.svg logos. From what I know Kodi doesn't accept SVGs and only works with PNGs. So a file type check is probably needed to weed out those SVGs. For example, TMDB has a SVG only and Fanart has PNG then choose the logo from Fanart instead. Or if TMDB has SVG and PNG both then choose PNG and disregard SVG.

I'll find some time to fix the logo destination and then take a deeper look at the SVG thing.

Here's the PR for the change discussed above.
https://github.com/xbmc/metadata.tvshows...on/pull/83

I ended up closing that PR because I fixed it and the SVG stuff in other commits.  There's a version you can test for Matrix or Nexus.

My development environment is switched over for Nexus, so the Nexus version has more complete filtering of SVGs and a couple other image related changes that were not straight forward to back port to Matrix.  The Matrix version does the clearlogo categorization and filters for SVGs in a couple placed (like clear logos) but not everywhere.

[monisriz]

@pkscout  So how do I update to the version with these changes? My current addon version says 1.4.13 - is that the right version?

[Karellen]

So how do I update to the version with these changes?

Click on either the Matrix or Nexus link. Download the Zip file, then install via zip in Kodi.

[monisriz]

So how do I update to the version with these changes?

Click on either the Matrix or Nexus link. Download the Zip file, then install via zip in Kodi.

Ok.. so the TMDB TV Show scrapper won't update on it's own like other addons do when there's an update?

[pkscout]

So how do I update to the version with these changes?

Click on either the Matrix or Nexus link. Download the Zip file, then install via zip in Kodi.

Ok.. so the TMDB TV Show scrapper won't update on it's own like other addons do when there's an update?

It will when there is an actual official update.  Since I can't test these changes on Matrix (as mentioned before, my development environment is all Nexus now), I need someone to make sure it both works as expected and doesn't cause other issues.  Once that is confirmed I will push the update to the scraper repo, after which auto updating will happen.

[monisriz]

Click on either the Matrix or Nexus link. Download the Zip file, then install via zip in Kodi.

Ok.. so the TMDB TV Show scrapper won't update on it's own like other addons do when there's an update?

It will when there is an actual official update.  Since I can't test these changes on Matrix (as mentioned before, my development environment is all Nexus now), I need someone to make sure it both works as expected and doesn't cause other issues.  Once that is confirmed I will push the update to the scraper repo, after which auto updating will happen.

Did a quick test against 7-8 tv shows. Didn't see the "logos" section under "Choose Art". TMDB logos seem to be appearing correctly under clearlogo section.
Also tested with a show that had both svg and png files and only png showed up in the clearlogo preview area.

[pkscout]

Ok.. so the TMDB TV Show scrapper won't update on it's own like other addons do when there's an update?

It will when there is an actual official update.  Since I can't test these changes on Matrix (as mentioned before, my development environment is all Nexus now), I need someone to make sure it both works as expected and doesn't cause other issues.  Once that is confirmed I will push the update to the scraper repo, after which auto updating will happen.

Did a quick test against 7-8 tv shows. Didn't see the "logos" section under "Choose Art". TMDB logos seem to be appearing correctly under clearlogo section.
Also tested with a show that had both svg and png files and only png showed up in the clearlogo preview area.

Great.  Thanks for checking.  I'll probably push the official update out this weekend.  Because the one you tested is the same code and the same version number as what will get pushed out, you won't get an update, but everyone else will.  '-)