2022-05-20, 22:49
(2022-05-20, 21:58)emveepee Wrote: @enen92 how are you considering implementing this? I have briefly been playing with this for NextPVR recordings (server side) and it seems to work as expected, but I would think most people would want PVR_EDL_TYPE_COMBREAK anyway, the TV series intro's are often too sort, 15-30 seconds to reach for the remount. Are you suggesting a new type with a skip intro OSD?I am still not sure 100% sure.
Martin
My idea at a basic level is just to extend MPlayer EDL (which by now is pretty much Kodi specific since it includes more edit types than what MPlayer used to support) with a new (or more than one) types/ids. The one or more IDs is my main doubt currently.
Generically, intro/outros/recaps are all the same if we try to categorize them into an edit type. They are "skippable sections" (sections than can be skipped automatically if the user chooses to set Kodi to do so) or (by default) sections which the user may skip upon a button prompt. The only difference between them is a label.
So my idea is to have a new EditType linked to a string/label. Just like commbreaks, this new type must add a scene marker at the begin and end of the section.
Then we need to add a few infolabels/bools (Player.InEdit, Player.CurrentEditType, etc).
Then we can relegate the button to skins just like shown here:
https://forum.kodi.tv/showthread.php?tid...pid3084062
Hitting the button would execute Next (iirc the built-in correctly) which will skip to the next scene marker (== end of the skippable section).
Not a big deal to implement but I preferred to fix old edl/edit types that were previously broken (mute and cut).
Cheers