[Longtime Collector]

... but everything else about music playback and display continued to work as normal... just the slideshow had stopped.

[Longtime Collector]

I'm still having the issue where the slideshow stops although the rest of Kodi seems to hum merrily along. No big deal, I'll eventually find out what's happening.

I noticed in the extrafanart discussions on the wiki there are unelaborated limitations to the number and naming of fanart images and I wonder if anyone might know if either of these limitations are important to the smooth operation of the artistslideshow. I download additional fanart images keeping their original filenames. Some of the filenames reach the limit of filename sizes allowable for Windows. Some of the artists have well over 30 images.

Also, I now have over 30K images accessed over a rather slow Raspberry Pi NAS setup. Are there any timing issues for retrieving these images that might stop processing? I'm using a separate artistslideshow folder.

[pkscout]

I think the number and naming of images to which you are referring has to do with the Kodi Artist Information Folder.  If you aren't using that, or if you are but don't have AS using it, none of that will matter to AS.  I have several artists with well over 100 images, and AS churns through them with no problem.  I also have mine on a NAS, although it's a Synology and plenty fast.  A slow NAS might mean a short delay in showing an image, but it shouldn't cause a crash.

The addon has never done any name length checks.  If the image length will violate the OS limits, it is possible that is causing the crash.  I'd need a debug log of it happening to see how I can trap for it and then just not download the image (or maybe change it's name).

[Longtime Collector]

Thanks for the feedback. Again I don't yet know what is the issue. But I wanted to eliminate some possible causes and your reply was helpful. There are all sorts of variables still to be investigated.

[Longtime Collector]

Well it didn't crash the slideshow (I don't think) but the following lines showed up in debug:

2023-05-19 18:18:08.259 T:64748   debug <general>: [Artist Slideshow] Image was not a valid Kodi image type, nothing added: M:\Music\ΩArtistSlideshow\Latimore\IMG_3145 - Latimore.JPG
2023-05-19 18:18:08.259 T:64748   debug <general>: [Artist Slideshow] Valid Kodi image types are:
2023-05-19 18:18:08.259 T:64748   debug <general>: [Artist Slideshow] ('.png', '.jpg', '.jpeg', '.bmp', '.gif', '.ico', '.tif', '.tiff', '.tga', '.pcx', '.cbz', '.zip', '.rss', '.webp', '.jp2', '.apng')
2023-05-19 18:18:08.259 T:64748   debug <general>: [Artist Slideshow] Image was not a valid Kodi image type, nothing added: M:\Music\ΩArtistSlideshow\Latimore\IMG_3414 - Latimore, Bobby Rush.JPG
2023-05-19 18:18:08.259 T:64748   debug <general>: [Artist Slideshow] Valid Kodi image types are:
2023-05-19 18:18:08.260 T:64748   debug <general>: [Artist Slideshow] ('.png', '.jpg', '.jpeg', '.bmp', '.gif', '.ico', '.tif', '.tiff', '.tga', '.pcx', '.cbz', '.zip', '.rss', '.webp', '.jp2', '.apng')
2023-05-19 18:18:08.260 T:64748   debug <general>: [Artist Slideshow] Image was not a valid Kodi image type, nothing added: M:\Music\ΩArtistSlideshow\Latimore\IMG_3416 - Latimore, Bobby Rush.JPG
2023-05-19 18:18:08.260 T:64748   debug <general>: [Artist Slideshow] Valid Kodi image types are:
2023-05-19 18:18:08.260 T:64748   debug <general>: [Artist Slideshow] ('.png', '.jpg', '.jpeg', '.bmp', '.gif', '.ico', '.tif', '.tiff', '.tga', '.pcx', '.cbz', '.zip', '.rss', '.webp', '.jp2', '.apng')
2023-05-19 18:18:08.260 T:64748   debug <general>: [Artist Slideshow] Image was not a valid Kodi image type, nothing added: M:\Music\ΩArtistSlideshow\Latimore\P1000360 - Latimore.JPG

does Artistslideshow NOT recognize caps in extensions?

[pkscout]

does Artistslideshow NOT recognize caps in extensions?

Please don't post log snippets in forum posts.  In the future post a link to the full log as per forum rules.

That said, it appears AS does not support uppercase extensions.  It's been this way for like three and a half years, and you're the first one to notice.  Or at least notice and say anything about it.  AS gets the list of image extensions from Kodi, and they are all in lowercase.  It looks like an easy fix to support uppercase extensions, but it'll be a few days for me to get the fix in and approved.  In the meantime, if you are up for modifying one line of code, you can edit the following file:

addons/script.artistslideshow/resources/lib/artistslideshow.py

On line 119 replace the line that says:

python:
if path.endswith(self.VALIDIMAGETYPES):

with:

python:
if path.lower().endswith(self.VALIDIMAGETYPES):

[Longtime Collector]

Thanks for this. Hopefully it was the reason for my earlier issue (During testing I stopped Kodi once the slideshow stopped).

[Longtime Collector]

Still have issues.
I had two previously scraped images in the artistslideshow folder and they were skipped by the addon. The artist was Daniel Boone ... I noticed the scraper went to scrape at tmbd.org instead of theaudiodb.com if that means anything.

https://paste.kodi.tv/jesemabeho.kodi

Daniel Boone - Beautiful Sunday.mp3

Images in the artistslideshow folder that were skipped:
svxvyx1469142858.jpg
vwytqx1469142848.jpg

[pkscout]

Still have issues.
I had two previously scraped images in the artistslideshow folder and they were skipped by the addon. The artist was Daniel Boone ... I noticed the scraper went to scrape at tmbd.org instead of theaudiodb.com if that means anything.

https://paste.kodi.tv/jesemabeho.kodi

Daniel Boone - Beautiful Sunday.mp3

Images in the artistslideshow folder that were skipped:
svxvyx1469142858.jpg
vwytqx1469142848.jpg

Looking at that log, it appears that at 2023-05-19 22:30:30.999 Kodi sent a PlaybackStopped message right after you started playing M:\Music\t-z\Will Bradley · Ray McKinley - Beat Me, Daddy, Eight to the Bar.mp3.  That tells AS to stop, which it did.  There's no indication of a window change though, and then at 2023-05-19 22:30:31.009 playback starts again but with M:\Music\#-d\Daniel Boone - Beautiful Sunday.mp3.  There were a couple of busy dialogs that came up, but no indication that you had left or come back to the music visualization window.

In most skins going to the music visualization window is what triggers AS to start.  Once it stops, it won't start again until you exit and go back to that screen.  I'm guessing there is some problem with that Will Bradley/Ray McKinley mp3 that caused Kodi to stop playback and then go to the next song, but in a way that you never exited the music visualization screen.

You've got a couple options.

• figure out what caused Kodi to choke on the playback of that MP3
  
• change how AS is started so it never stops
  

For the second one, you need to find the MusicVisualization.xml for your skin and find the line that says:

xml:
<onload>RunScript(script.artistslideshow)</onload>

And change it to:

xml:
<onload>RunScript(script.artistslideshow, daemon=True)</onload>

That will keep AS from quitting even when Kodi says music playback has stopped.  When playback starts again, AS will start checking for images again.

[Longtime Collector]

Thanks. I'll try option 2 and let you know how it works.

[Longtime Collector]

I may have to ask you to go beyond the call of duty. I made the change you suggested (estuary skin) and NO images showed up (black screen). I needed to go into administrator mode to make the change.

https://paste.kodi.tv/vifimijoqe.kodi

I changed back and still had the black screens. I needed to restore the prior version of the MusicVisualization.xml from a backup in order to see the images again.

This may be a windows thing, but perhaps you've seen this before?

Thx

[pkscout]

I may have to ask you to go beyond the call of duty. I made the change you suggested (estuary skin) and NO images showed up (black screen). I needed to go into administrator mode to make the change.

https://paste.kodi.tv/vifimijoqe.kodi

I changed back and still had the black screens. I needed to restore the prior version of the MusicVisualization.xml from a backup in order to see the images again.

This may be a windows thing, but perhaps you've seen this before?

Thx

That usually means you in some way saved an invalid XML file.  I'm not able to troubleshoot that for you.

[Longtime Collector]

Sorry you must be getting tire of me ... but I do love ArtistSlideshow and want it to be even better.

Kodi crashes with ArtistSlideShow addon enabled:
https://paste.kodi.tv/loxaraneko.kodi

Kodi doesn't crash with ArtistSlideshow addon disabled:
https://paste.kodi.tv/juneyamade.kodi

The offending artist is LS Jack

LS Jack has no fanart in the ArtistSlideshow folder, and 1 image (fanart.jpg) in the ArtistArtwork folder.

The mp3 and the jpg both seem to be without problems.

I have successfully entered the two changes earlier discussed (upper case extensions and musicvisualization.xml)

[pkscout]

Kodi crashes with ArtistSlideShow addon enabled:
https://paste.kodi.tv/loxaraneko.kodi

That log doesn't show anything that would indicate why Kodi crashed, and ArtistSlideshow didn't generate any kind of exception.  Technically all ArtistSlideshow does is provide a path to an image.  The skin actually displays it.  I don't know why the skin crashes with that image, but there isn't anything I can do about that.

[izprtxqkft]

considering kodi is crashing and it involves loading images, i see you are using path substitution for the thumbnails folder, be aware this comes with warnings - https://kodi.wiki/view/Path_substitution

it would be recommendable to disable the substitution and see if any behavior is changed

-----

also, i just noticed the omega symbol in your path Ω in the interest of eliminating potential concerns i would also recommend trying without this - not all fonts can handle it and in some instances will cause strange behavior up to and including crashes