Login at Kodi Home

forest · 2024-09-27, 02:57

Hi, folks.

I submitted PR #24943 to make switching subtitle tracks easier, and although it has been assigned a reviewer, I haven't seen a response from anyone. The contributing guidelines suggest letting the maintainers know if a PR has been standing for too long, but they don't say how. Should I do that here? In a comment on the PR? A mailing list or IRC channel?

About six months have passed since I submitted it.

**Karellen** · 2024-09-27, 03:22

Yes, it has been sitting around for a while.

Just a bump post in the PR is best. Possibly ping CastagnaIT in the post along with Fuzzard. CastagnaIT overhauled the subtitles system a few years ago, so would be best to comment and fuzzard generally reviews a lot of PR's.
Garbear deals in Games, so probably won't review your PR.

Boilerplate4U · 2024-10-10, 21:20

@forest, anything that makes managing subtitles easier is more than welcome!

**scott967** · 2024-10-10, 22:51

You're probably going to need to look at 25762 (PR) which changes the GUI dialogs and 25813 (PR) for the functionality.

scott s.
.

forest · 2024-10-11, 20:29

CastagnaIT kindly looked over the PR, and I added what he asked for. That was a couple weeks ago.

If someone here is in a position to merge it, I think it's ready.

(2024-10-10, 21:20)Boilerplate4U Wrote: @forest, anything that makes managing subtitles easier is more than welcome!

Thanks!

(2024-10-10, 22:51)scott967 Wrote: You're probably going to need to look at 25762 (PR) which changes the GUI dialogs and 25813 (PR) for the functionality.

Thanks. I looked, and those changes don't seem to step on mine, so I think we're fine.

forest · 2024-12-01, 21:18

This PR was labeled and added to the "Piers 22.0 Alpha 1" milestone a couple months ago, but hasn't been merged yet. Is something more needed from me in order to move it forward?