Login at Kodi Home

amasephy

Yes at 21 and 40. The search bar shouldn’t be visible off to the right where there’s nothing below and the media items are coming into view from the left.

Even if search was active, it’s in the wrong spot.

I thought this was new because of your stack rework? I definitely could be mistaken but I don’t recall seeing this before.

Buschel · 2024-10-05, 16:22

Ah, I talked about something different. Now I see what you had in mind. Could be a regression, will look at it. Just me me know, if you find anything else.

UlfSchmidt · 2024-10-05, 18:52

I am experiencing severe issues with album covers with the latest test flight, several of these images are now missing out of a sudden. Also other strange things happen now, see this video:
YouTube

UlfSchmidt · 2024-10-05, 19:38

(2024-10-05, 18:52)UlfSchmidt Wrote: I am experiencing severe issues with album covers with the latest test flight, several of these images are now missing out of a sudden. Also other strange things happen now, see this video:
YouTube

Sorry, my NAS was down and I didn’t recognize it. And it seems also Kodi didn’t notice.

Buschel · 2024-10-05, 19:51

Ok, do any of the issues persist?

UlfSchmidt · 2024-10-05, 19:59

I am not sure how the App behaves in regular cases when there is no fanart, cover etc. stored for a specific item on the server?
Will it behave as shown in my video where accidentally no artwork was provided by the server? Or is there a difference?
Currently, I don’t have anything without artwork on my server, so it’s difficult for me to verify.

Buschel

In the video an error happens when downloading from a given URL. This error can be handled better and I raised a PR in the last minutes (#1160). In other cases, like no fanart or cover given, this was never a problem.

But what about issues related to the stack rework? No other issues or glitches observed?

UlfSchmidt · 2024-10-05, 20:28

(2024-10-05, 20:23)Buschel Wrote: But what about issues related to the stack rework? No other issues or glitches observed?

Sorry, but I was completely distracted by the missing artwork. Will retest this tomorrow.

Buschel · 2024-10-05, 20:31

Sounds good, but anyway no waste of time as you had this NAS problem. It showed a robustness issue with the album view which is now improved. 👍

UlfSchmidt · 2024-10-05, 20:33

Love your attitude Wink

UlfSchmidt · 2024-10-06, 09:30

(2024-10-05, 20:28)UlfSchmidt Wrote:
(2024-10-05, 20:23)Buschel Wrote: But what about issues related to the stack rework? No other issues or glitches observed?

Sorry, but I was completely distracted by the missing artwork. Will retest this tomorrow.

It is really so much fun using the current test flight. During my testing everything worked flawlessly.

Only the following minor improvements might be implemented in addition, if the community (@Buschel, @amasephy ) follows my thoughts:

When entering Global Search, I would expect that the Search field becomes automatically visible (as the name Global Search somehow implies)
I wonder if it would be possible to sort the result list also within items sharing the same label, e.g. when I search for a song like „Take a chance on me“ I would appreciate to see the results also ordered by year, so that ABBA‘s original is listed first, followed by the Erasure interpretation and then by the remake for their first cinematic movie.
When entering Global Search without entering anything in the Search field, all sections except Songs are presented in alphabetical order. Please apply your label sort also already here for Music, if possible.

Buschel · 2024-10-06, 11:16

Great, good to see there's nothing obvious broken which I missed during my testing. So the only issue currently is what @amasephy already reported on the shortly visible view with the searchbar which is moved to the invisible area.

(2024-10-06, 09:30)UlfSchmidt Wrote: When entering Global Search, I would expect that the Search field becomes automatically visible (as the name Global Search somehow implies)

I am sure this could be done, if it is desired.

(2024-10-06, 09:30)UlfSchmidt Wrote: I wonder if it would be possible to sort the result list also within items sharing the same label, e.g. when I search for a song like „Take a chance on me“ I would appreciate to see the results also ordered by year, so that ABBA‘s original is listed first, followed by the Erasure interpretation and then by the remake for their first cinematic movie.

Possible, but too much complication from my point if view. This requires multiple sort commands, e.g. first sort by artist, then sort by year, then sort by label. And there might be different preferences for this logic causing more debates. Smile

(2024-10-06, 09:30)UlfSchmidt Wrote: When entering Global Search without entering anything in the Search field, all sections except Songs are presented in alphabetical order. Please apply your label sort also already here for Music, if possible.

Well, I would like to keep the order which Kodi provides (the App does not request a specific sort order but leaves it to Kodi). The songs are somehow grouped per album in this mode.

Buschel

(2024-10-06, 11:16)Buschel Wrote: Great, good to see there's nothing obvious broken which I missed during my testing. So the only issue currently is what @amasephy already reported on the shortly visible view with the searchbar which is moved to the invisible area.

Reproducible via: Have a view opened > click into searchbar > enter a character > end search by clicking "Cancel" > go to fullscreen > leave fullscreen.
This is not a regression of the stack rework and happens with current mainline as well.
No sure yet how to resolve ...

Edit: Root cause is found. Could already resolve the issue seen in the video, but am looking at this for other use cases as well.

amasephy · 2024-10-06, 20:11

The only thing I noticed with the stack view controller is you have less control over its movement now. For example you cannot slide it to the left as much anymore (it didn’t stay at that position) and the lack of being able to slide it mostly off view now to the right like you could before. Was this intended? Video to follow if this wasn’t intended.

Buschel

There are fewer „stable“ positions now. If there is only 1 view, it will always snap back to its origin. If there‘s two views the underlying will always snap left (partially covering the main menu), the top one can either snap to be fully visible (overlapping the underlying one), or snap more to the right to fully unveil the underlying one (itself being partially outside the visible area).

Is this a real loss of usability from your point of view, or just a difference you noticed?