[bkury]

Nice.
The only thing I'm still missing is the name of the location on home screen in the upper right corner, directly over the textual weather condition description. But this is really very minor.

Got it, will be fixed in the next update.
I'll wait until the weekend, in case anything else comes up.

Thanks!

[ksooo]

One more: I switched language in Kodi to German. Then, in Estuary, the daily forecast tiles show all "None" instead of the short week day (Mo, Di, Mi, ...).

[bkury]

One more: I switched language in Kodi to German. Then, in Estuary, the daily forecast tiles show all "None" instead of the short week day (Mo, Di, Mi, ...).

Yes, I already noticed that too. I even fixed a very weird exception that happenend when changing languages :
 
* Fixed exception when changing languages (possibly a KODI bug)
* Note: Changing language throws an exception without enforcing utf8, possibly a KODI bug

It seems like changing languages forces KODI to do something funky with the LanguageInvoker (python) thread. I haven't had time to look at the c++ code yet but to me it seems like a KODI bug.
Restarting KODI fixes it but I'll try to debug it in the next days.

[bkury]

v0.9.5 is now available, Estuary MOD users may also upgrade to this version ...

Download:
weather.openmeteo-0.9.5

Changelog:

Code:

v0.9.5 (26/10/2024)
-------------------
* Fixed exception when disabling, uninstalling or upgrading the addon

v0.9.4 (25/10/2024)
-------------------
* Added day & night weather icon support for KODIs built-in weather codes
* Added addon operation modes: Compatibility (default) or Advanced <onload>SetProperty(openmeteo,skin.xyz,weather)</onload>
* Added "current.location" to fix KODIs built-in "weather.location" infolabel
* Localization mapping is now dynamic to fix broken labels when changing languages
* Enforce utf8 with open() to fix exception when changing languages
* Changed "Decimal places" setting to sliders
* ImageMagick: Use PNG32 to fix broken graph if value is zero or below threshold

Note to skin developers:
This addon can now operate in two different modes: Compatibility (default) or Advanced mode. If you want to use features like graphs, I highly recommend switching to "advanced" mode by setting <onload>SetProperty(openmeteo,skin.xyz,weather)</onload>. I will post an integration guide about the differences between these modes soon.

[Raitsa]

Thanks for the new 0.9.4, off to install.

Been using this happily in 3 Nvidia Shield Pros since the first version.
Updating takes about... 4 mins or so, thats the only strange thing in this great addon.
Usually Kodi addons install in seconds.

[jim_p]

I tried upgrading it a few moments ago and this happened. From 0.9.2 straight to 0.9.4, on libreelec 10 running kodi 19 (do not ask why unless you want to hear complaints about libreelec 11 and 12). Trying again installed it with no warnings.
 

Code:

2024-10-25 19:19:16.475 T:889     ERROR <general>: EXCEPTION: Unknown addon id 'weather.openmeteo'.
2024-10-25 19:19:16.477 T:889     ERROR <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'RuntimeError'>
                                                   Error Contents: Unknown addon id 'weather.openmeteo'.
                                                   Traceback (most recent call last):
                                                     File "/storage/.kodi/addons/weather.openmeteo/service.py", line 4, in <module>
                                                       service.Main()
                                                     File "/storage/.kodi/addons/weather.openmeteo/lib/service.py", line 58, in Main
                                                       utils.setsetting('service', 'stopped')
                                                     File "/storage/.kodi/addons/weather.openmeteo/lib/utils.py", line 23, in setsetting
                                                       xbmcaddon.Addon().setSetting(arg, str(value))
                                                   RuntimeError: Unknown addon id 'weather.openmeteo'.
                                                   -->End of Python script error report<--

[bkury]

Thanks! Seems like KODI didn't stop the addon correctly before upgrading. I'll take a look and add a workaround for that in case KODI can't handle weather addons with a service.

You can safely ignore this error for now, re-installing should fix it

[ksooo]

> One more: I switched language in Kodi to German. Then, in Estuary, the daily forecast tiles show all "None" instead of the short week day (Mo, Di, Mi, ...).

Thanks for the update.
Question: Is the above problem supposed to be fixed with 0.9.4? Still seeing "None" instead of short day of day representation when switching Kodi language to German, even after restarting Kodi.

[bkury]

Question: Is the above problem supposed to be fixed with 0.9.4? Still seeing "None" instead of short day of day representation when switching Kodi language to German, even after restarting Kodi.

Well, at least I thought so yes. It's working fine on my setups with v0.9.4 now.

Can you give me more info about your installation? (OS, KODI version, skin, etc)

[ksooo]

> Can you give me more info about your installation? (OS, KODI version, skin, etc)

Sure: macOS, Kodi latest master (self-compiled), Stock Estuary

[bkury]

Hotfix:
weather.openmeteo-0.9.5
 

Code:

v0.9.5 (26/10/2024)
-------------------
* Fixed exception when disabling, uninstalling or upgrading the addon

Note: Upgrading to this version will still throw an error but going forward from v0.9.5 everything should be fine.

Updating takes about... 4 mins or so, thats the only strange thing in this great addon.

That's strange indeed. Please provide some logs the next time you upgrade.

Sure: macOS, Kodi latest master (self-compiled), Stock Estuary

I'm a little bit lost here, tested it with KODI 21 on windows, linux & android and with KODI master on windows & linux, forecast weekday labels are working fine even after changing the language multiple times.
Unfortunately, I currently don't have a MacOS device to test with but it would be weird if this issue is OS related.

Do you also have this problem with a new KODI profile or can you test it on a different machine?

[ksooo]

> it would be weird if this issue is OS related

Yes, but can confirm it working on Android and not working for macOS. Tested with same Kodi version.

> Do you also have this problem with a new KODI profile or can you test it on a different machine?

Tried with 0.9.5, same problem with master user profile, newly created user profile, and even with completely new Kodi userdata

Nuked Kodi userdata. Started Kodi. Language == default == English.
Installed OpenMeteo 0.9.5. Enabled it. Did no config. Worked like a charm. It picked up my location automatically etc. Short day of week displayed correct (Mo, Tu, Th, ...).
Switched Kodi language to German in Kodi Regional Settings. OpenMeteo picked up new language immediately, except short day of week info in daily forecast tiles being all "None" now.

And a feature request: Would it be possible to support 5 different locations? This is what I used with multiwheather.

[bkury]

Yes, but can confirm it working on Android and not working for macOS. Tested with same Kodi version.

Thanks for testing.

That's Interesting, it's very likely a KODI issue then. I can only think of one workaround this time and that depends if the addon localization is still working in your case, so here is a question:
When forecast weekday labels are showing "None", do the map labels (Radar, Satellite, Wind) still work or are they also showing "None" ?
 

And a feature request: Would it be possible to support 5 different locations? This is what I used with multiwheather.

It's already in the code but disabled on purpose because having 5 locations active might hit some API limits. You could test and enable it yourself with these 2 simple changes:
 

• Edit weather.openmeteo/resources/settings.xml and uncomment location 4 & 5
  
• Edit weather.openmeteo/lib/config.py and change "maxlocs" to 6
  
• Restart KODI
  

You might want to check your kodi.log after 24+ hours to make sure that you didn't get any 4xx http errors which would indicate that you hit some API limit.

[ksooo]

> When forecast weekday labels are showing "None", do the map labels (Radar, Satellite, Wind) still work or are they also showing "None" ?

Yes, they seem to be in English, but not "None".

[bkury]

Download:
weather.openmeteo-0.9.6
 

Code:

v0.9.6 (27/10/2024)
-------------------
* Moved global localization strings (e.g. Monday, Mon, NNE) from KODI directly to the addon:
  Workaround for broken labels when changing languages on macOS
* Fixed "current.[LOCID]" in advanced mode
* Fixed a rare case of Addon & KODI service running simultaneously on startup