[Rf67]

It's working flawlessly. Great job. Thanks for the share. I'm going to see what suggestions to mske

[AngryBird]

@Officer KD6-3.7

I noticed none of my DTSHD/DTSX audio was showing codec information on labels.

Just looking at some of the code
<value condition="[String.Contains(VideoPlayer.AudioCodec,dtshd) | String.Contains(VideoPlayer.AudioCodec,dts_hd)]">DTS-HD</value>

I believe the only strings that can be found in Kodi are:
dtshd_ma
dtshd_hra

For DTSX it would be dtshd_ma only, I don't believe there is much dtshd_hra out there as it's an older variation not used anymore.

[Officer KD6-3.7]

@AngryBird Really sorry about that but I just noticed I made a typo in the 'Label_ListItem_Sur_Tech' variable (I wrote 'dts-hd' instead of 'dtshd' when checking for the audio codec).
The one you posted is the 'Label_VideoPlayer_Sur_Tech' -- i.e. when the Video Player is active (which fortunately works because the string 'dtshd_ma' contains 'dtshd'). You can test this by playing the file and selecting the DTS-HD audio track.  

I'll fix it in the next version but you can change the code in the meanwhile to check if it's working
In the Includes_Labels.xml file replace the two variables ('Label_ListItem_Sur_Tech and Label_VideoPlayer_Sur_Tech ) with the code below

Code:

<variable name="Label_ListItem_Sur_Tech">
        <value condition="String.Contains(ListItem.FileNameAndPath,truehd) + String.Contains(ListItem.AudioCodec,truehd)">TRUEHD</value>
        <value condition="String.Contains(ListItem.FileNameAndPath,atmos) + [String.Contains(ListItem.AudioCodec,truehd) | String.Contains(ListItem.AudioCodec,eac3)]">ATMOS</value>
        <value condition="[String.Contains(ListItem.FileNameAndPath,dtsx) | String.Contains(ListItem.FileNameAndPath,dts-x)] + String.Contains(ListItem.AudioCodec,dtshd_ma)">DTS-X</value>
        <value condition="[String.Contains(ListItem.FileNameAndPath,dtshd) | String.Contains(ListItem.FileNameAndPath,dts-hd)] + String.Contains(ListItem.AudioCodec,dtshd)">DTS-HD</value>
        <value condition="!String.IsEmpty(ListItem.AudioCodec)">$INFO[ListItem.AudioCodec]</value>
    
        <value condition="String.Contains(Container(99950).ListItem.Property(base_filenameandpath),truehd) + String.Contains(Container(99950).ListItem.Property(base_audiocodec),truehd)">TRUEHD</value>
        <value condition="String.Contains(Container(99950).ListItem.Property(base_filenameandpath),atmos) + [String.Contains(Container(99950).ListItem.Property(base_audiocodec),truehd) | String.Contains(Container(99950).ListItem.Property(base_audiocodec),eac3)]">ATMOS</value>
        <value condition="[String.Contains(Container(99950).ListItem.Property(base_filenameandpath),dtsx) | String.Contains(Container(99950).ListItem.Property(base_filenameandpath),dts-x)] + String.Contains(Container(99950).ListItem.Property(base_audiocodec),dtshd_ma)">DTS-X</value>
        <value condition="[String.Contains(Container(99950).ListItem.Property(base_filenameandpath),dtshd) | String.Contains(Container(99950).ListItem.Property(base_filenameandpath),dts-hd)] + String.Contains(Container(99950).ListItem.Property(base_audiocodec),dtshd)">DTS-HD</value>
        <value condition="!String.IsEmpty(Container(99950).ListItem.Property(base_audiocodec))">$INFO[Container(99950).ListItem.Property(base_audiocodec)]</value>
    </variable>
    <variable name="Label_VideoPlayer_Sur_Tech">
        <value condition="String.Contains(VideoPlayer.AudioCodec,truehd)">TRUEHD</value>
        <value condition="String.Contains(Player.FilenameAndPath,atmos) + [String.Contains(VideoPlayer.AudioCodec,truehd) | String.Contains(VideoPlayer.AudioCodec,eac3)]">ATMOS</value>
        <value condition="[String.Contains(Player.FilenameAndPath,dtsx) | String.Contains(Player.FilenameAndPath,dts-x)] + String.Contains(VideoPlayer.AudioCodec,dtshd_ma)">DTS-X</value>
        <value condition="String.Contains(VideoPlayer.AudioCodec,dtshd)">DTS-HD</value>
        <value condition="!String.IsEmpty(VideoPlayer.AudioCodec)">$INFO[VideoPlayer.AudioCodec]</value>
    </variable>

 

Also, if anyone has access to files with multiple audio tracks with different codecs (example a movie with a TrueHD and a DTS-HD MA track or a EAC3 track etc.), please let me know if the labels still work (i.e. will Kodi grab the AudioCodec of the first/default track and match it with the filenameandpath). 
Just checked with my BladeRunner 2049 and Dune file and it determines the order as listed in the variable (irrespective of the order of audio tracks)
It'll check for TRUEHD > then ATMOS (either TRUEHD or EAC3) > DTS-X > DTS-HD

I think most home releases/blu-rays usually come with DTS audio so an argument could be made to give those preference over their Dolby counterparts (simply need to reorder the value conditions in the variable). Like if you named your file 'Dune Part One (2021)_TrueHD with Atmos_DTS-HD', would you rather want 'TRUEHD' or 'DTS-HD' to show up in the info line?

Or I could add a setting, something like 'Preferred audio codec in info line: Dolby/DTS' and it will check those first accordingly.
But let me know if that makes things too convoluted (too many goddamn settings lol!). I understand that is mostly a very 'enthusiast'/'niche' topic for people that care about their local files haha.

Sorry about the bug and thank you for letting me know!

[etgecata]

Hello, thank you for your work.
Is it possible to add two functions:
1. Option for instead of icons-the name:

2. Four lines of information:

[AngryBird]

@AngryBird Really sorry about that but I just noticed I made a typo in the 'Label_ListItem_Sur_Tech' variable (I wrote 'dts-hd' instead of 'dtshd' when checking for the audio codec).
The one you posted is the 'Label_VideoPlayer_Sur_Tech' -- i.e. when the Video Player is active (which fortunately works because the string 'dtshd_ma' contains 'dtshd'). You can test this by playing the file and selecting the DTS-HD audio track.  

I'll fix it in the next version but you can change the code in the meanwhile to check if it's working
In the Includes_Labels.xml file replace the two variables ('Label_ListItem_Sur_Tech and Label_VideoPlayer_Sur_Tech ) with the code below

Also, if anyone has access to files with multiple audio tracks with different codecs (example a movie with a TrueHD and a DTS-HD MA track or a EAC3 track etc.), please let me know if the labels still work (i.e. will Kodi grab the AudioCodec of the first/default track and match it with the filenameandpath). 
Just checked with my BladeRunner 2049 and Dune file and it determines the order as listed in the variable (irrespective of the order of audio tracks)
It'll check for TRUEHD > then ATMOS (either TRUEHD or EAC3) > DTS-X > DTS-HD

I think most home releases/blu-rays usually come with DTS audio so an argument could be made to give those preference over their Dolby counterparts (simply need to reorder the value conditions in the variable). Like if you named your file 'Dune Part One (2021)_TrueHD with Atmos_DTS-HD', would you rather want 'TRUEHD' or 'DTS-HD' to show up in the info line?

Or I could add a setting, something like 'Preferred audio codec in info line: Dolby/DTS' and it will check those first accordingly.
But let me know if that makes things too convoluted (too many goddamn settings lol!). I understand that is mostly a very 'enthusiast'/'niche' topic for people that care about their local files haha.

Sorry about the bug and thank you for letting me know!

Ahh, got it.  I'm still learning.  And yes, I guess dtshd_ma and dtshd_hra both contain the string dtshd   Silly me.

I've learned a lot by looking at your code.  Always interesting to see what you and jm have done.  It's been forever since I've done any real coding.

Personally, I never keep more than the one lossless audio codec when ripping my discs.  Since both my Shield and Zidoo play everything, I exclude anything else using MakeMKV or MKVToolnix to save space.  If I did keep anything else it would be AC3 or EAC3 for compatibility, but don't have anything in my library currently.

[BigRedJim]

@Officer KD6-3.7 Something I have been toying with is an on-screen pop up to confirm when a HDR file is played. So for example the Dolby Vision logo comes up for a few seconds when you play a DV movie, HLG for HLG etc. I know some TV's do this automatically but mine does not, so maybe a toggle in the settings would also be appropriate as I imagine people who have sets that already do this would find it annoying. I have the PNG files for the logos but haven't had any success in my limited attempts to get it working. Is that something you might be able to incorporate into your Mod do you think?

[RmdcF1967]

In Categories, below the icon and name of the category, it displays "Addon".
I think this line could be eliminated, leaving just the Name and the icon for the category (if possible, could the icons be in color?). If not, could it be possible to display the name of the addon used for that category?
Thanks

[Officer KD6-3.7]

@etgecata - Those sound like very cool features to backport from AF2. Although, I am not nearly as good of a coder as Jurial (not even close) to do the whole 'Expanded Info' thing, I'm 100% going to try to see if I can add at least 1 more line of plot by adjusting some height parameters.

@AngryBird - Haha I guess we're the same! Storage does become a concern when you're addicted to only having REMUXES lol. A fallback EAC3/AC3 track is more than good enough for 99% of cases. And now that I think about it the 'Preferred audio codec' setting would make things too confusing and it's better to keep things simple. I've also heard that Kodi v22 is going to use a newer version of ffmpeg that can read atmos, dts-x, etc. in the audiocodec so that'd make this whole feature more accurate without relying on file names

@BigRedJim - That does sound like a very interesting idea but I'm afraid the skin cannot detect the HDR capabilities of the user's display. So having a logo pop up could be a little misleading for some users.
The HDR tags added to the VideoPlayer OSD signify the presence of HDR metadata in the videostream (but that does not guarantee that your display actually supports that HDR format).
If you were to play a DV or HDR10 file on a non-HDR display (like on an old laptop), you'd still see the DV/HDR10 tag in the video OSD info line but everything would look 'flat'. You'd need to enable tonemapping for the colors to look right.

Here's a different example: Samsung TVs do not support Dolby Vision (they don't want to pay Dolby the licensing fees so they developed their own dynamic HDR format - HDR10+).
If you were to play a DV file on their TVs, you'd only actually be seeing the fallback/base HDR10 data (which is static HDR metadata as opposed to Dolby Vision and HDR10+ which utilize a frame-by-frame dynamic luminance approach).
In this case, Kodi is still going to show the DV tag in the OSD (because the video stream does have dolbyvision metadata) but you can't technically see it because the display doesn't support that format. So if we were to have the DV logo pop up here, it would be quite misleading.

@RmdcF1967 - Can you please share a screenshot so I can understand what you mean? 

Thank you guys! Y'all are awesome! Keep the cool ideas and features coming!

[etgecata]

I don't know if @RmdcF1967 has this change in mind. But it would be very useful if there was an option to write the name of the add-on from the ribbon instead of the Home name (in this example-max)

[BigRedJim]

@BigRedJim - That does sound like a very interesting idea but I'm afraid the skin cannot detect the HDR capabilities of the user's display. So having a logo pop up could be a little misleading for some users.
The HDR tags added to the VideoPlayer OSD signify the presence of HDR metadata in the videostream (but that does not guarantee that your display actually supports that HDR format).
If you were to play a DV or HDR10 file on a non-HDR display (like on an old laptop), you'd still see the DV/HDR10 tag in the video OSD info line but everything would look 'flat'. You'd need to enable tonemapping for the colors to look right.

Here's a different example: Samsung TVs do not support Dolby Vision (they don't want to pay Dolby the licensing fees so they developed their own dynamic HDR format - HDR10+).
If you were to play a DV file on their TVs, you'd only actually be seeing the fallback/base HDR10 data (which is static HDR metadata as opposed to Dolby Vision and HDR10+ which utilize a frame-by-frame dynamic luminance approach).
In this case, Kodi is still going to show the DV tag in the OSD (because the video stream does have dolbyvision metadata) but you can't technically see it because the display doesn't support that format. So if we were to have the DV logo pop up here, it would be quite misleading.

That's a good point and one I hadn't considered, as my TV plays all types of HDR. I will go back to trying to figure this out myself. Thanks!

[AngryBird]

Here's a different example: Samsung TVs do not support Dolby Vision (they don't want to pay Dolby the licensing fees so they developed their own dynamic HDR format - HDR10+).
If you were to play a DV file on their TVs, you'd only actually be seeing the fallback/base HDR10 data (which is static HDR metadata as opposed to Dolby Vision and HDR10+ which utilize a frame-by-frame dynamic luminance approach).
In this case, Kodi is still going to show the DV tag in the OSD (because the video stream does have dolbyvision metadata) but you can't technically see it because the display doesn't support that format. So if we were to have the DV logo pop up here, it would be quite misleading.

I'm one with a Samsung who doesn't want/need the DV label.  I ended up deleting the DV line and adding 2 filename searches.  I had to search the filename for HDR10 along with HDR10plus because as far as I found Kodi only keeps the one HDRType and you never know what the fallback HDR is with Kodi.  Plus I didn't want both a HDR10 and a HDR10+ label.  Basically, I just ignore whatever Kodi has except for HLG.

        <value condition="String.Contains(ListItem.FileNameAndPath,.hdr10plus.)">HDR10+</value>
        <value condition="String.Contains(ListItem.FileNameAndPath,.hdr10.)">HDR10</value>
        <value condition="String.IsEqual(ListItem.HdrType,hlg)">HLG</value>
        <value>SDR</value>

I suppose one could make an option the user could set for the type of TV they have.

Good to see that Kodi will eventually detect more audio codecs.

[jonathanwine1985]

Fantastic work you've done with this mod! I can't wait to see what you come up with next!

Also, I appreciate how you've taken the time address your stance on the mod. Give credit where credit is due. Address issues promptly and offer quick fixes if applicable with rationale behind them. Friendly and engaging demeanor all the while maintaining humbleness. Speaks volumes of your character!

[AngryBird]

Instead of playing with HDR options I decided to show both DV and the HDR10 fallback if there is one



So, for videos which are DV profile 7/8 it will show either "DV HDR10" or "DV HDR10+" and for DV profile 5 it would be just "DV" because there is no fallback.

[RmdcF1967]

Hi guys.
On the atacched photo is what I referred. Below the Category name there's a lina that says Add-on. Can it be turn off or show the name of the add-on instead(in this case it's fen lite)? And can the icons be in colour?

Thanks

[Officer KD6-3.7]

@AngryBird - Those info tags look very cool!
I'm a bit hesitant to solely rely on file names to do the HDR tags (since that will again rely on the user's library naming/tagging) and AFAIK Kodi's ListItem.Hdrtype only offers 3 values (dolbyvision, hdr10 and hlg). Although, Kodi can play HDR10+ videos, it doesn't offer that as a string for ListItem infolabels.

Also, HDR10+ and Dolby Vision are both dynamic HDR types so I'm not sure if one can serve as a fallback to the other. Although there are discs that offer both HDR types, the fallback (i.e. if your device doesn't support either HDR10+ or DV except Profile 5) is probably going to be HDR10 (HDR10 is open source and the most basic type - essentially meaning HDR10 = HDR. All HDR displays should support this).

I think Kodi can only check for the first Hdrtype anyway. In a best case scenario, where you entire chain (TV, player, AVR, etc.) supports both HDR types, I don't think there's a setting in Kodi to choose which HDR type to play on the fly. Blu-ray players (Panasonic, Oppo, etc.) do have that option.

On Kodi nightlies since February, there is a setting (shoutout to quietvoid) to discard the HDR data from the stream if your device doesn't support it and also convert DV Profile 7 to 8.1 on the fly. So if you have access to hybrid files but only choose to play a specific HDR format, you can use this setting to achieve that.

And I know I'm going way off topic here haha, but DV and HDR10+ aren't that different in visual/technical quality. The biggest difference is availability.
There are 1885 movies released in DV, 134 in HDR10+ and 85 that offer both.

Extremely sorry for the rambling! But I hope some of it was useful haha!

@BigRedJim - I still think that pop up logo idea is quite cool and something that can be added under 'Expert' settings with an experimental tag. Currently, I can do a toggle where the user can select their display HDR capabilities (OFF, DV, HDR10, HLG and ALL) and the pop up is going to take that setting along with the current playback HDR type into consideration. But this setting is going to rely entirely on the user selecting the correct option. Also, no HDR10+ until Kodi adds that in the core.

@jonathanwine1985 - Thank you so much for the kind words! It truly means a lot to me! Jurial has given the community some of the best skins of all time so I feel like I'm standing on the shoulders of a giant. Although, work/life can sometimes get hectic and I may take a few days to reply, I will try my best to keep this mod alive and thriving with the help of all of you! 

@etgecata - I am not sure if I can change the name of the hub to dynamically display the category name, but I'll take a look at the code and see if something else is possible.

@RmdcF1967 - Ahh I see what you mean! You probably have Categories set to 'Detailed'. Go to Settings > Skin > Interface > Categories and change it to 'Icon'. You can already get colored icons there, try using the Providers from TMDb Helper TV Shows

Next update is going to have tiny bug fixes and small visual tweaks (unless one of you posts any game changing ideas here!) and will probably be done by Sunday. Will keep y'all posted with any progress/updates!

Thank you!