[opdenkamp]

without looking in the code: return "false" when Create() fails and don't set the module's status to STATUS_OK.

but if you're spending time on this, why not spend time on getting vnsi working on windows? streamdev is deprecated and will be removed from the tree soon.

[joniw]

Hello dushmaniac

I followed your advise and tried to get the vnsi plugin to work. It now is clear, that it will go the same way as the streamdev plugin in providing different macros for the network functions.

It will cost some time but i think i will get it to work.

While testing with the vnsi plugin i just noticed a problem with your code in the process function of the pvrmanager.

Because it tries to load the plugins again and again when there is not plugin selected for loading it puts heavy load on the cpu.

I am running in debug mode and have 80 % CPU utilization (with a dual core processor). The log shows lines like this:

0:59:55 T:5056 M:1460506624 DEBUG: PVRManager - CPVRManager::TryLoadClients - all clients loaded
00:59:56 T:5716 M:1460932608 DEBUG: Previous line repeats 26419 times.
00:59:56 T:5716 M:1460932608 ERROR: CRemoteControl::Connect - failed to connect
00:59:56 T:5056 M:1460932608 DEBUG: PVRManager - CPVRManager::TryLoadClients - all clients loaded
01:00:00 T:5716 M:1459691520 DEBUG: Previous line repeats 102878 times.
01:00:00 T:5716 M:1459691520 DEBUG: CRemoteControl::Connect - connecting to: 127.0.0.1:24000 ...
01:00:00 T:5056 M:1459695616 DEBUG: PVRManager - CPVRManager::TryLoadClients - all clients loaded
01:00:01 T:5716 M:1459830784 DEBUG: Previous line repeats 26266 times.


Another Problem is that you can not disable the PVR part in the settings if you don't have at least one pvr client running because the process is stuck in the while loop. This can be fixed by adding "&& !m_bstop" in the while loop of the process() function.

By the way is it ok if i post this here or should i attach patch files?

with regards

Joniw

[opdenkamp]

I'll fix TryLoadClients(). Please send patches as pull requests on github.