[cramm]

I've tested on windows, android with the same results.

Actually the kodi team want the addons to be compatible to python 2 and 3 for kodi 18 leia in order for the addon to be in their resository, then kodi 19 will only take python 3.
more information about it here: https://kodi.tv/article/attention-addon-...n-python-3

they also created a support group for addon developers to help with the changes required:

https://forum.kodi.tv/forumdisplay.php?fid=281

 Thanks for the info about platforms you are using Kodi 18 on.

Re: Python 3. Again, what you say is incorrect, you can verify reading the official blog post I linked above. It reads " Addon developers are encouraged to convert their addons to Python 2/3-compatible so that after the release of Kodi 19 (M*) we will have enough addons that work with the new version."

It would be completely crazy to make compatibility with Python 3 a requirement for Kodi 18 at this point of the development cycle (the linked official blog post is dated January 2018)

Also, no official Kodi 18 release build will include Python 3 and third party packagers would be bonkers if they decide to build their Kodi linked against python 3. So there is no point in porting an addon to Python 3 at this point when not even Kodi 18 has been released.

Anyway, Python 3 isn't the reason of this failure.

[cramm]

 I can confirm that it is still not working. I am not skilled enough so as to debug the inner working. If anyone can comment on how to do so, I may give it a try.

Any help will be welcomed.

Please state your platform (Windows, Linux, Android, etc.)

Thanks!   

Am using an Android s905 box with LibreELEC 8.90.4.
I have spent some time yesterday going through the Python script trying to debug it, and it seems that .rar compressed files are the culprit as XBMC.Extract is unable to process it as reported elsewhere.
Same addon for downloading zip compressed files works fine.

Tried to get some information on the built in function XBMC.extract, but could not find any.

Downloaded .rar file is present and available. I double checked that with SFTPing into the box.

I have checked the suggested forum threads and bug report at GitHub and apparently a workaround could be to use vfs for accessing the rar downloaded file.

Some info here:
https://forum.kodi.tv/showthread.php?tid=323321

My almost non existant knowledge in Python prevents me from going any further in fixing the Addon.   

Exactly!

I've found the same thread after following some leads someone in the #kodi IRC channel gave me (namely, adding "vfs" to the Google search). Posted a link to a GitHub issue: https://github.com/ramiro/service.subtit...-368245655

I'm trying to work on an updated version which uses the libarchive VFS addon instead of XBMC.Exctract

Would you be willing to test a development build of the addon?

Anyway, I still need to confirm this would not break things for people using versions of Kodi older than 18.

Thanks!

[abescalamis]

I've tested on windows, android with the same results.

Actually the kodi team want the addons to be compatible to python 2 and 3 for kodi 18 leia in order for the addon to be in their resository, then kodi 19 will only take python 3.
more information about it here: https://kodi.tv/article/attention-addon-...n-python-3

they also created a support group for addon developers to help with the changes required:

https://forum.kodi.tv/forumdisplay.php?fid=281

 Thanks for the info about platforms you are using Kodi 18 on.

Re: Python 3. Again, what you say is incorrect, you can verify reading the official blog post I linked above. It reads " Addon developers are encouraged to convert their addons to Python 2/3-compatible so that after the release of Kodi 19 (M*) we will have enough addons that work with the new version."

It would be completely crazy to make compatibility with Python 3 a requirement for Kodi 18 at this point of the development cycle (the linked official blog post is dated January 2018)

Also, no official Kodi 18 release build will include Python 3 and third party packagers would be bonkers if they decide to build their Kodi linked against python 3. So there is no point in porting an addon to Python 3 at this point when not even Kodi 18 has been released.

Anyway, Python 3 isn't the reason of this failure.         

 I went to read the official blog post again and that is what I understood in this part:

"After the release of Kodi 18 (Leia) only addons that are compatible with both Python 2 and 3 will be accepted to the official addon repository. Also, Python 3-only addons will be accepted to the repositories for Kodi 19 (M*) and above."

Yes they did an official release of Kodi 18 with python 3 for addon developers here is the link, is also in that same new blog post:

Windows:
http://mirrors.xbmc.org/test-builds/windows/win32/

Linux:
https://launchpad.net/~wsnipex/+archive/.../+packages

They only want the addons to be compatible with python 2 and 3 in order to allow them in their kodi 18 repository, but the addon will work even if it has not python 3 support, it just that it won't be in their official repository but this is not a problem the addon can be install from a zip, and for kodi 19 and newer addon's will have to be python 3.

Please look at this, it will make more clear whats coming:

https://kodi.wiki/view/General_informati...o_Python_3

I don't know what the issue is, but if you need me to test a beta addon count me in, I can also test it on kodi 17 if you need me to.

[Gaudi]

Please state your platform (Windows, Linux, Android, etc.)

Thanks!   

Am using an Android s905 box with LibreELEC 8.90.4.
I have spent some time yesterday going through the Python script trying to debug it, and it seems that .rar compressed files are the culprit as XBMC.Extract is unable to process it as reported elsewhere.
Same addon for downloading zip compressed files works fine.

Tried to get some information on the built in function XBMC.extract, but could not find any.

Downloaded .rar file is present and available. I double checked that with SFTPing into the box.

I have checked the suggested forum threads and bug report at GitHub and apparently a workaround could be to use vfs for accessing the rar downloaded file.

Some info here:
https://forum.kodi.tv/showthread.php?tid=323321

My almost non existant knowledge in Python prevents me from going any further in fixing the Addon.   

Exactly!

I've found the same thread after following some leads someone in the #kodi IRC channel gave me (namely, adding "vfs" to the Google search). Posted a link to a GitHub issue: https://github.com/ramiro/service.subtit...-368245655

I'm trying to work on an updated version which uses the libarchive VFS addon instead of XBMC.Exctract

Would you be willing to test a development build of the addon?

Anyway, I still need to confirm this would not break things for people using versions of Kodi older than 18.

Thanks!

Sure, I can help with the testing.
BTW, as you will be editing the addon, would it be possible to dynamically adjust description height (or make it a little bit taller overall), many subtitles have long descriptions that are truncated, and sometimes the hidden text shows the release information to help decide which version to download.

Thanks

[cramm]

BTW, as you will be editing the addon, would it be possible to dynamically adjust description height (or make it a little bit taller overall), many subtitles have long descriptions that are truncated, and sometimes the hidden text shows the release information to help decide which version to download.

 Unfortunately the sizing isn't under the addon control. It's something which Kodi or rather the skin (Estuary), controls We only pass back to Kodi the list of items (in this case search results) and we have no way to infuence anything about the appeareance. We are tracking  this with a GitHub issue: https://github.com/ramiro/service.subtit.../issues/23 but there isn't much we can do apart from converting the addon from a subtitles addon to a totally standalone plugin like e.g. the Trakt addon and use the GUI facilities provided by Kodi which allows one to actually create more powerful windows, dialogs and widgets.

[Gaudi]

BTW, as you will be editing the addon, would it be possible to dynamically adjust description height (or make it a little bit taller overall), many subtitles have long descriptions that are truncated, and sometimes the hidden text shows the release information to help decide which version to download.

 Unfortunately the sizing isn't under the addon control. It's something which Kodi or rather the skin (Estuary), controls We only pass back to Kodi the list of items (in this case search results) and we have no way to infuence anything about the appeareance. We are tracking  this with a GitHub issue: https://github.com/ramiro/service.subtit.../issues/23 but there isn't much we can do apart from converting the addon from a subtitles addon to a totally standalone plugin like e.g. the Trakt addon and use the GUI facilities provided by Kodi which allows one to actually create more powerful windows, dialogs and widgets.

Thanks for the explanation. I would say that the inconvenience is not worth having to develop a standalone add-on.
As it only takes a blink to download a different subtitle most important thing will be to have the extracting issue fixed.
As I mentioned before, am fully open to test, and if you could point to the right tool I can research and try to do some debugging.

[Gaudi]

@cramm, have you got any time to develop a test version?

Thanks!

[cramm]

@cramm, have you got any time to develop a test version?

Please test version 0.2.10 which is all about just trying to fix this issue on Kodi 18. It should not change behavior on older Kodi releases.

You can download a ZIp file from https://github.com/ramiro/service.subtit...0.2.10.zip then install it via the 'Install from ZIP archive' option of Kodi.

Note that starting with this version and for Kodi version >= 18 we rely on a so-called 'binary' add-on: vfs.libarchive by developer notspiff to be able to uncompress RAR files containing subtitles. I suspect most of the subtitles on subdivx.com are RAR-compressed.

Unfortunately it is not possible to trigger an automatic installation of vfs.libarchive via the Kodi add-on dependency system. This  means you need to go to Add-ons > My add-ons > All addons and activate there the 'Archive support' add-on (that's the name vfs.libarchive appears with). If you don't do that you will keep getting errors when you try to download a subtitle.

I'll keep trying to get an answer to the question if it is possible to get this dependency resolution process automated in some way be it either on the #kodi-dev IRC channel (no luck so far) or on these forums and will implement needed changes before the next official 0.3.0 release of this add-on.

Note: This isn't an official release. It's a test version only distributed via a Git tag and its corresponding ..ZIP file from GitHub (https://github.com/ramiro/service.subtit...bdivx/tags)

[cramm]

I don't know what the issue is, but if you need me to test a beta addon count me in, I can also test it on kodi 17 if you need me to. 

 Please see https://forum.kodi.tv/showthread.php?tid...pid2710695

if you can, it would be great if you test it both on Kodi 18 and Kodi 17. It should not change anything for Kodi 17 and older.

[abescalamis]

Its working great on Kodi 18, tested on windows and Android, but for Kodi 17 the problem is that the vfs.libarchive is not present so it cannot be enable, I will install it manually and will report

Update!!!!

For kodi 17, there is no need to enable the vfs.libarchive, the test addon worked perfectly

[cramm]

Its working great on Kodi 18, tested on windows and Android, but for Kodi 17 the problem is that the vfs.libarchive is not present so it cannot be enable, I will install it manually and will report

Update!!!!

For kodi 17, there is no need to enable the vfs.libarchive, the test addon worked perfectly

Exactly, the new dependency on vfs.libarchive is just for Kodi 18 or newer.

Thnaks for the testing and feedback.

[Gaudi]

Thank you for taking your time to fix the addon. Have downloaded and installed with no issues. Dependency was already enabled in my LibreELEC 8.90.4 for Amlogic S905.
Unfortunately I have not got the opportunity to test it with local media as my NAS is down.

Will try to get some from backup and comment back.


Regards

[Gaudi]

Quick test results.
Used file manager to launch movies from a USB drive.
Addon does not seem to work properly to search for subtitle. All movies tested show no results.
Manually entering movie name result in several subtitles listed, but some of them fail to download.
Could not check yet the log to confirm why is it failing.

[abescalamis]

I installed it on 2 kodi's 18 and 1 kodi 17.6, I haven't have any issue so far, we been using it for a few days.

[cramm]

Release 0.3.0 is in progress including the changes for compatibility with Kodi 18 Leia.

Should be available from the official Kodi add-on repository in the next dew days. Kodi will auto-upgrade or will offer the upgrade.