Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
2008-12-31, 02:06
hey,
after seeing all the polite and constructive requests, as well as some not so constructive whining, for a better music scraper, i finally gave in and did it myself.
r16773
let the bug reporting commence
Posts: 4
Joined: Jun 2008
Reputation:
0
Wow nice, thank you for the work you did!
I had a quick go with it and it seems to work.. 4 new albums got scraped nicely using 'Update library'. 1 album came back with false results, though. I'll try to figure out what went wrong later today and report back.
Posts: 582
Joined: Dec 2008
Reputation:
2
nice, just tried it today on a rather small collection of music, just one thing to report.
discography doesn't work for any artist.
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
artist scrapes i have hardly worked on, personally i still use allmusic for artists
Posts: 4
Joined: Jun 2008
Reputation:
0
Finally had some time to do more testing; I cleared my music library today and ran album lookups using the discogs scraper on 50+ albums. All mp3s have proper id3 tags, i always use musicbrainz picard before anything is added to the library.
Think I've found one bug, which looks fixable. Not sure though if it's the scraper or XBMC's scraper framework which is broken. The details for Albums with a single quote in their name are never fetched from discogs. That is: the GetAlbumSearchResults thingy is executed (i have wireshark and strace logs that show the discogs HTTP request and response), but the album details lookup is never executed.
When looking up the album details XBMC briefly shows the 'Looking up album names..' dialog, which then disappears without further notice.
I'll try to create a patch and submit it.
Posts: 148
Joined: Jan 2009
Reputation:
0
Where can I get the file ??
Posts: 7
Joined: Jan 2009
Reputation:
0
im not clear on how to get this or how to install...
can someone please help...thanks
Posts: 1,970
Joined: Nov 2008
Reputation:
1
azido
Posting Freak
Posts: 1,970
yeah spiff.. once again you've made my day. this is a real reason to update to the latest svn - thanks! i'll report asap.
Posts: 15,282
Joined: Jan 2009
Reputation:
739
ronie
Team-Kodi Member
Posts: 15,282
hey spiff,
not sure if you're still interested in maintaining this scraper,
but fetching album info / album artwork does not work anymore.
grabbing artist info / artist thumb still works without a problem.
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
create a ticket please and we'll see if it pops up on top
Posts: 1,473
Joined: Aug 2004
Reputation:
3
C-Quel
Retired Team-Kodi Member
Posts: 1,473
2009-03-26, 21:30
(This post was last modified: 2009-03-26, 23:17 by C-Quel.)
change the <GetAlbumSearchResults> expression to
\n<a href="([^"]*/release/[^"]*)".*?>(.*?) - (.*?)</a>
Posts: 15,282
Joined: Jan 2009
Reputation:
739
ronie
Team-Kodi Member
Posts: 15,282
thanx to the both of you for the quick replies.
i grapped the modified scraper from svn, but no luck.
to make it work, i had to change the regex to:
<a href="([^"]*/release/[^"]*)".*?>(.*?) - (.*?)</a>