[Asteron]

in my python script i noticed xbmcgui.window.getfocus() was not returning the correct control. i traced this problem to

guilib/guiwindow.cpp

int cguiwindow::getfocuscontrol()
{
for (int i=0; i < (int)m_veccontrols.size(); ++i)
{
cguicontrol* pcontrol= m_veccontrols[i];
if (pcontrol->hasfocus()) return i;
}
return -1;
}

it is returning the control index
lib/libpython/xbmcmodule/window.cpp - window_getfocus() assumes it is returning the control id. does any other code use this function and is counting on a control index?

i think the line should be changed to

if (pcontrol->hasfocus()) return pcontrol->getid();

i'd do the fix myself but dont have an environment setup (traced this just by browsing the cvs on sourceforge).

[Bobbin007]

there is a function called getfocusedcontrol(). this returns the id of the focused control.

greets

bobbin007

[Asteron]

lol ok... then the bug is just in

xbmc/lib/libpython/xbmcmodule/window.cpp - window_getfocus()

...
icontrolid = pwindow->getfocuscontrol();
...

should be

...
icontrolid = pwindow->getfocusedcontrol();
...

can someone make the fix? thanks

-ast

[Bobbin007]

fixed in cvs forgotten to reply

greets

bobbin007